Re: test/subtest flow control with exceptions

--MGYHOYXEY6WxJCY8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Chad Granum <[email protected]> [2016-11-30T10:30:38]
> I do have implementation commentary however:

Thanks, greatly appreciated!

>  * You should not be obtaining a context inside your subtest (specifically
> line 18

So, I've moved it to after the eval.  I (think that I) need it inside the
subtest so that the events emitted from the abort exception occur inside the
subtest, rather than above it.  But if you think that moving that line down=
 is
correct... I've done it!

> https://github.com/rjbs/Test-Abortable/blob/master/lib/Test/Abortable.pm#=
L30
>  this should probably be $ctx->throw() which is essentially a die, but it

I wrote a long refutation of this only to see that you reversed your opinion
one sentence later!  This is more proof that I should really read the whole
thing before beginning my reply!

Thanks for your review!

--=20
rjbs

--MGYHOYXEY6WxJCY8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJYP1g+AAoJEOYby6cMccU5e/8IAIdt4moOOH+/pEucQXO1d0mJ
hEurUKwil3uAYCk/3BXwtzumwI33sSoUE9gRWLdRNM/wvX1aM9LPlPYwHp5fXM1v
r8AcZTKV3QvzhSSsanXeolNRkYFQp4OX1nbgAgm6RjN/463+rsf3oyVhJKmlRcGG
WrtNrLKjXNwdheuMng80TRxCfwtlIS+1v4ec0IpP5S0zrgLpCD6DQRQPFpG/lZRG
u8RKpH7eaRyd4ejCgaz4IkTBOsSZ69uwgn01IzlI8PBxlkaWa+DJqeamOsjEvl/G
Jht6BEQviyWMnMXp+IZzg2geSXUOOYIkIlXXFp1oCbeAQSjcr3MAk1olDh7HMzs=
=5n6N
-----END PGP SIGNATURE-----

--MGYHOYXEY6WxJCY8--