Aw: Re: Issues in the current HEAD
[email protected] ("Hans Salvisberg") Mon, 5 Jan 2015 13:44:39 +0100
| Newsgroups | perl.qpsmtpd |
|---|---|
| Message-ID | <trinity-41bb2dea-8b49-4f13-9689-b22639e1f2d7-1420461879353@3capp-gmx-bs46> |
<html><head></head><body><div style="font-family: Verdana;font-size: 12.0px;"><div> <div>No, this produces</div> <div> </div> <div> <div>Deep recursion on subroutine "Qpsmtpd::Transaction::DESTROY" at lib/Qpsmtpd.pm line 271.<br/> Deep recursion on subroutine "Qpsmtpd::log" at lib/Qpsmtpd/Transaction.pm line 242.<br/> Deep recursion on subroutine "Qpsmtpd::varlog" at lib/Qpsmtpd.pm line 93.<br/> Deep recursion on subroutine "Qpsmtpd::run_hooks_no_respond" at lib/Qpsmtpd.pm line 105.<br/> Out of memory!</div> <div> </div> <div>Hans</div> </div> <div> <div name="quote" style="margin:10px 5px 5px 10px; padding: 10px 0 10px 10px; border-left:2px solid #C3D9E5; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"> <div style="margin:0 0 10px 0;"><b>Gesendet:</b> Montag, 05. Januar 2015 um 01:35 Uhr<br/> <b>Von:</b> "Matt Simerson" <[email protected]><br/> <b>An:</b> "Hans Salvisberg" <[email protected]><br/> <b>Cc:</b> "Jared Johnson" <[email protected]>, "[email protected]" <[email protected]><br/> <b>Betreff:</b> Re: Issues in the current HEAD</div> <div name="quoted-content"> <div> <div> <blockquote> <div>On Jan 4, 2015, at 3:38 PM, Hans Salvisberg <<a href="[email protected]" target="_parent">[email protected]</a>> wrote:</div> <div> <div> <div style="font-family: Verdana;font-size: 12.0px;"> <div> <div>Going to the new HEAD</div> <div> b1abc66 - qpsmtpd: Add additional dependency for geoip: Math::Complex. (2015-01-03 18:29:08 +0100)</div> <div> <div>has brought some relief:</div> <div> </div> <div>Handle 2 now gives me only 7 instances of</div> <div> </div> <div> <div>FATAL PLUGIN ERROR [logging::file_3a7]: Can't call method "notes" on unblessed reference at /home/smtpd/qpsmtpd/plugins/logging/file line 275.</div> <div> </div> <div>anymore, even though I still have 4 file loggers enabled. Plus one</div> <div> </div> <div> <div>5014 XX: Can't call method "notes" on unblessed reference at /home/smtpd/qpsmtpd/plugins/logging/file line 275.</div> <div> </div> <div>And the warn_handler message is indeed gone, at least in my test case! Thanks!</div> <div> </div> <div>Hans</div> </div> <div> </div> </div> </div> </div> </div> </div> </div> </blockquote> <div> </div> <div>Seems to be a bug in that logging plugin:</div> <div> </div> <div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> <span style="color: rgb(172,170,33);">if</span> ( !<span style="color: rgb(46,184,197);">$self->{</span><span style="color: rgb(193,53,30);">_f</span><span style="color: rgb(46,184,197);">}</span></div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> || !<span style="color: rgb(46,184,197);">$self->{</span><span style="color: rgb(193,53,30);">_nosplit</span><span style="color: rgb(46,184,197);">}</span></div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> || !<span style="color: rgb(46,184,197);">$transaction</span></div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;color: rgb(193,53,30);background-color: rgb(255,253,195);"><span style="color: rgb(0,0,0);"> || !</span><span style="color: rgb(46,184,197);">$transaction->notes</span><span style="color: rgb(0,0,0);">(</span>'file-logged-this-session'<span style="color: rgb(0,0,0);">))</span></div> <div> </div> </div> <div>The last line is 275, and apparently $transaction isn't a reference there. $transaction can be an empty hash defined in ::Qpsmtpd, which seems like a dumb default, as it will cause arrow operations like this one to blow up). Try this and see if it helps:</div> <div> </div> <div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);">--- a/lib/Qpsmtpd.pm</div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);">+++ b/lib/Qpsmtpd.pm</div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;color: rgb(46,184,197);background-color: rgb(255,253,195);">@@ -244,7 +244,10 @@ sub _load_package_plugin {</div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> return $plug;</div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> }</div> <p style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);min-height: 15.0px;"> </p> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;color: rgb(193,53,30);background-color: rgb(255,253,195);">-sub transaction { return {}; } # base class implements empty transaction</div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;color: rgb(48,185,35);background-color: rgb(255,253,195);"> <div style="margin: 0.0px;">+sub transaction {</div> <div style="margin: 0.0px;">+ eval 'use Qpsmtpd::Transaction';</div> <div style="margin: 0.0px;">+ return Qpsmtpd::Transaction->new();</div> <div style="margin: 0.0px;">+}</div> </div> <p style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);min-height: 15.0px;"> </p> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> sub run_hooks {</div> <div style="margin: 0.0px;font-size: 14.0px;font-family: Inconsolata;background-color: rgb(255,253,195);"> my ($self, $hook) = (shift, shift);</div> <div> </div> </div> <div> </div> <div>Matt</div> <div> </div> <blockquote> <div> <div> <div style="font-family: Verdana;font-size: 12.0px;"> <div> <div> <div> </div> <div style="margin: 10.0px 5.0px 5.0px 10.0px;padding: 10.0px 0 10.0px 10.0px;border-left: 2.0px solid rgb(195,217,229);"> <div style="margin: 0 0 10.0px 0;"><b>Gesendet:</b> Sonntag, 04. Januar 2015 um 06:11 Uhr<br/> <b>Von:</b> "Jared Johnson" <<a href="[email protected]" target="_parent">[email protected]</a>><br/> <b>An:</b> "<a href="[email protected]" target="_parent">[email protected]</a>" <<a href="[email protected]" target="_parent">[email protected]</a>><br/> <b>Cc:</b> "<a href="[email protected]" target="_parent">[email protected]</a>" <<a href="[email protected]" target="_parent">[email protected]</a>><br/> <b>Betreff:</b> Re: Issues in the current HEAD</div> <div> <p>Regarding the warn_handler message, I probably managed to mess up my recently merged <a href="https://github.com/smtpd/qpsmtpd/pull/168" target="_blank">https://github.com/smtpd/qpsmtpd/pull/168</a> for xinetd mode. Unfortunately my availability will be spotty this week. As a temporary fix, you could use a different mode (I recorded prefork) or un-merge that PR. Of course this may be the least of your problems.</p> <div class="gmail_quote">On Jan 3, 2015 5:12 PM, <a href="[email protected]" target="_parent">[email protected]</a> wrote: <blockquote class="quote" style="margin: 0 0 0 0.8ex;border-left: 1.0px rgb(204,204,204) solid;padding-left: 1.0ex;"> <div> <div>I'm using xinetd according to <a href="http://wiki.qpsmtpd.org/doku.php?id=deploy:start" target="_blank"> http://wiki.qpsmtpd.org/doku.php?id=deploy:start</a>, i.e. no daemon mode but just running<br/> <br/> exec qpsmtpd<br/> <br/> <br/> -----Ursprüngliche Nachricht-----<br/> Gesendet: Saturday, 03 January 2015 um 23:31:06 Uhr<br/> Von: "Jared Johnson" <<a href="[email protected]" target="_parent">[email protected]</a>><br/> An: "<a href="[email protected]" target="_parent">[email protected]</a>" <<a href="[email protected]" target="_parent">[email protected]</a>><br/> Betreff: Re: Issues in the current HEAD<br/> <br/> What daemon mode are you using? Prefork?<br/> --<br/> *** DoubleCheck identified this as CLEAN. Give feedback:<br/> *** This is SPAM: <a href="http://filter.emailportal.com/" target="_blank">http://filter.emailportal.com</a><br/> *** More options: <a href="http://filter.emailportal.com/" target="_blank">http://filter.emailportal.com</a></div> </div> </blockquote> </div> </div> </div> </div> </div> </div> </div> </div> </blockquote> </div> </div> </div> </div> </div> </div></div></body></html>