Re: Patch to smtp-forward

On 2010-09-15 00:14:10 -0700, Robert Spier wrote:
> Tony Lambiris wrote:
> > Thoughts on the following changes to smtp-forward? These diffs were taken
> > against the svn smtp-forward checked out yesterday.
> > 
> > Thanks.
> 
> What are your intentions with this change?  It's very much
> not-backwards compatible as it changes the possible results of the
> plugin from OK and DECLINED to OK, DENY, and DENYSOFT.

It looks like the old behaviour wasn't intentional:

return(DECLINED, "Unable to queue message ($!)");

That looks strange to me. If you return DECLINED, qpsmtpd moves to the
next plugin. if there is no next plugin it return an error message ("no
suitable plugin for queuing found" or something like that) of its own
to the client. In any case the message will be lost, so that's
equivalent to 

return(DECLINED);

I have a strong suspicion that the author meant to write

return(DENY, "Unable to queue message ($!)");

But you are right, regardless of what the author meant to write, the
plugin has worked that way for years now, so silently changing the
default behaviour is not a good idea. I think it should be configurable.

	hp

-- 
   _  | Peter J. Holzer    | Openmoko has already embedded
|_|_) | Sysadmin WSR       | voting system.
| |   | [email protected]         | Named "If you want it -- write it"
__/   | http://www.hjp.at/ |  -- Ilja O. on [email protected]

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFMkHsDfZ+RkG8quy0RAlHmAKCmHywqJoniuQzo5yAIIdEYJnMApQCfdQSM
OFqe6Od0kyIzIAbCLmNJM+I=
=ClDj
-----END PGP SIGNATURE-----