Re: Patch to smtp-forward

On 9/15/2010 10:56 AM, Tony Lambiris wrote:
> My whole thing was, why send a 421 if the SMTP code returned from the
> actual relay/mailhub is "5xx Account disabled." or some other 5xx
> non-deliverable.

Right.

I will note that you haven't taken into account that the session might 
have dropped, and you won't have SMTP command codes to look at.

In our plugin, we retry almost every SMTP error _except_ "no such user".

Note to Robert: Net::Cmd permits you to look at the SMTP error codes.

>
> On Wed, Sep 15, 2010 at 10:17 AM, Chris Lewis <[email protected]
> <mailto:[email protected]>> wrote:
>
>     On 9/15/2010 3:51 AM, Peter J. Holzer wrote:
>
>         I have a strong suspicion that the author meant to write
>
>         return(DENY, "Unable to queue message ($!)");
>
>
>     The new code is considerably better - works properly in the face of
>     temporary vs permanent errors from the backend server and provokes
>     retries if appropriate.  It's how our (much hacked) smtp-forward works.
>
>     (our smtp-forward tries multiple backend servers, and does a limited
>     amount of optimizing which one to use.)
>
>     Parameterizing it for DECLINED vs DENY I guess would be best if
>     someone is expecting it to failover to another queuing plugin.  It's
>     more a notion of whether you have multiple queuing plugins or not.
>
>