Re: [PATCH] don't print GeoIP country if not defined
[email protected] (Robert Spier)
| Newsgroups | perl.qpsmtpd |
|---|---|
| Message-ID | <CAAroffdjp4Fv0qE0HdCuuoUHE5NZd9sLvi1G5bX1D08kAyWtwQ@mail.gmail.com> |
On Mon, Apr 23, 2012 at 8:39 AM, Matt Simerson <[email protected]> wrote: > > On Apr 22, 2012, at 11:45 PM, Robert Spier <[email protected]> wrote: > > > This change contains a bunch of unnecessary whitespace changes. This > can make it hard to trace back to original changes. I'm not saying there's > not a need for a whitespace cleanup, but I wonder if it would be better to > do it all at once? > > I agree entirely. > > If you will recall, I tried the 'do it all at once' approach a year ago. I > would love to see the entire code base run through perltidy and committed. > > Maybe the time has come to "do a release" (0.9?) and then open things up for major cleanups/changes. -R