Re: [PATCH] SMTP.pm, add missing ; and remove useless if

Applied.

On Sun, May 6, 2012 at 11:17 AM, Matt Simerson <[email protected]> wrote:

>
> SMTP.pm, add missing ; and remove useless if
>
> ---
> lib/Qpsmtpd/SMTP.pm |    6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/lib/Qpsmtpd/SMTP.pm b/lib/Qpsmtpd/SMTP.pm
> index 7c126dd..d8734b6 100644
> --- a/lib/Qpsmtpd/SMTP.pm
> +++ b/lib/Qpsmtpd/SMTP.pm
> @@ -54,18 +54,14 @@ sub dispatch {
>
>  if ($cmd !~ /^(\w{1,12})$/ or !exists $self->{_commands}->{$1}) {
>   $self->run_hooks("unrecognized_command", $cmd, @_);
> -    return 1
> +    return 1;
>  }
>  $cmd = $1;
>
> -  if (1 or $self->{_commands}->{$cmd} and $self->can($cmd)) {
>   my ($result) = eval { $self->$cmd(@_) };
>   $self->log(LOGERROR, "XX: $@") if $@;
>   return $result if defined $result;
>   return $self->fault("command '$cmd' failed unexpectedly");
> -  }
> -
> -  return;
> }
>
> sub unrecognized_command_respond {
> --
> 1.7.9.6
>
>