Re: [PATCH] basicheaders: improved POD and expanded tests

[email protected] (Charlie Brady) Fri, 18 May 2012 18:51:07 -0400 (EDT)

Newsgroups	perl.qpsmtpd
Message-ID	<[email protected]>

On Fri, 18 May 2012, Matt Simerson wrote:

> factored date validity tests into their own sub
> added tests

  improved POD

Excellent. But:

s/deffered/deferred/

and ...

> +# provide backwards comptibility with the old 'days' argument
> +    if ( $self->{_args}{days} ) {
> +        $self->log(LOGWARN, "deprecated arguments. Update your config.");

           $self->log(LOGWARN, "deprecated argument 'date'. Update your config.");

> +        if ( ! defined $self->{_args}{future} ) {
> +            $self->{_args}{future} = $self->{_args}{days};
> +        };