Re: FYR: modulereport

In article <[email protected]>,
 [email protected] (Janek Schleicher) wrote:



>       my ($ver, $cp) = @{$ref->{$_}};  

doh, should have thught of that...


> >     if (($ver || $cp) && !($ver && $cp)) {
> 
>          ($ver xor $cp)

nice. I forgot all about that one. 
 
> Couldn't find real bugs ;-)

thanks for the pointers. always good to get some feedback, but one of them, I think, 
is not right:

> > my $savefile  = File::Spec->catfile(
> >     File::Spec->curdir(),
> >     defined($opts{'f'}) ? $opts{'f'} : 'ModuleCheck.txt'
> 
>       $opts{f} ||= 'ModuleCheck.txt';
> 
> > );


this will work in this context? 
use File::Spec::Functions
my $savefile = 
    catfile( curdir(), defined($opts{'f'}) ? $opts{'f'} : 'ModuleCheck.txt');

vs

my $savefile = 
    catfile( curdir(), $opts{'f'} ||= 'ModuleCheck.txt');

I would think rather, 

    my $savefile = 
    catfile( curdir(), ($opts{'f'} || 'ModuleCheck.txt') );

now that I look at it. Am I dreaming or should I go test this?

print pack "H*", "4a75737420416e6f74686572204d61635065726c204861636b65722c0d";
-- 
Scott R. Godin            | e-mail : [email protected]
Laughing Dragon Services  |    web : http://www.webdragon.net/
It is not necessary to cc: me via e-mail unless you mean to speak off-group.
I read these via nntp.perl.org, so as to get the stuff OUT of my mailbox. :-)