Re: code review please

On Thu, Aug 20, 2009 at 5:52 PM, Kartik Thakore<[email protected]> wrote:
>
>
>> Hi,
>>
>
>> I'd appreciate if someone looked at them
>> and told me
>> how could they be improved.
>>
> I noticed use SDL; was missing for a lot of the scripts. Also when you make
> a new SDL::Event please do use SDL::Event;

Is the recommendation to just
use SDL;

and no need to explicitly load the various  SDL::* packages or shall I also use
SDL::App or shall I explicitly load each one of them I am using?

Once you tell me what is the recommendation, please also tell me why
is that? :-)

I think there is only one script where I use event objects without
explicitly creating one
in script 03-event-loop.pl where I was using the internal event loop that just
called the dispatch methods passing an event object to it.

I read somewhere that it is not recommended hence I later switch to
'active event loops'. So I wonder if this is really the case and why
is it not recommend
to use the internal event loop?


>
>> They can be found at
>> http://svn.perlide.org/padre/trunk/Padre-Plugin-SDL/share/examples/
>>
>> I have especial issues with 06-draw-line.pl   and   07-drag-object.pl
>> that are slow. How can improve the drawing speed in those scripts?
>>
>
> What version are you using?

2.2.0

but it is at least as slow if not slower with 1.20.3 that came with Ubuntu.


> Also if you got the newer version of sdl perl installed on windows care to
> share your secret?

no secret. I am using Ubuntu :-)

Gabor