Re: FB fixes

Fixed here http://bit.ly/90ZIjV !

2.210 is cpan's equivalent of 2.2.1.

We can just change the version number in lib/Games/FrozenBubble.pm
for your repo.


Kartik Thakore

On 2010-07-16, at 8:45 AM, Guillaume Cottenceau <[email protected]>  
wrote:

> On Thu, Jul 8, 2010 at 11:27 PM, Kartik Thakore
> <[email protected]> wrote:
>> Hi GC,
>>
>> We have fixed the two issues. Please review.
>
> overlook effect and selfspot seem correct now, congrats.
>
> however, it crashes on me with:
>
> [SDL Init] Can't locate object method "new" via package "SDL::Rect"
> (perhaps you forgot to load "SDL::Rect"?) at ./bin/frozen-bubble line
> 2685.
>
> unless I patch with:
>
> -=-=---=-=---=-=--
> diff --git a/bin/frozen-bubble b/bin/frozen-bubble
> index fd314ea..436fa5b 100755
> --- a/bin/frozen-bubble
> +++ b/bin/frozen-bubble
> @@ -64,6 +64,7 @@ use SDL::Events;
> use SDL::Color;
> use SDL::Cursor;
> use SDL::Mixer;
> +use SDL::Rect;
> use SDL::Mixer::Samples;
> use SDL::Mixer::Channels;
> use SDL::Mixer::Music;
> -=-=---=-=---=-=--
>
> strange it is not crashing on you? maybe not a full clean and rebuild
> on your side?
>
> (using SDL 2.502, Alien 1.410 and FB from git master)
>
>
> the rest seems fine so far
>
>
> I have an issue is with the versions. currently the server reports:
>
> Frozen-Bubble server version 0.001_1
>
> and the client reports:
>
> "Frozen-Bubble client version 2.210 (protocol version 1.2)
>
> to be logical with upgrade from current 2.2.0, I would like next
> release to be 2.2.1. is it feasible?
>
>
> also, the 2player music has a tempo of ~134 with mplayer, and ~125 in
> the game - I "felt" the music was too slow so I wrote this simple
> script and manually counted the tempo with it:
>
> http://zarb.org/~gc/t/count_tempo.rb
>
> funnily, introzik and 1player music are not affected... but I can
> assure this is a new problem, and it is probably related to the fact
> you've converted the .xm into a .ogg
>
> are you sure you cannot make mikmod work? else, someone out there
> still has a DOS under hand and could use FT2 there to save the .xm as
> a .wav and arrange to send me the .wav file?
>
> -- 
> Guillaume Cottenceau - http://zarb.org/~gc/