Re: Tcl::Tk Updates Ready for Release

On Mon, Oct 5, 2009 at 2:24 AM, Konovalov, Vadim (Vadim)** CTR ** <
[email protected]> wrote:

> > Hi Vadim,
> >
> > After much bug-fixing, I think the updated Tcl::Tk package is ready
> > for a release. As we talked a few months ago, the changes make Tcl::Tk
> > almost 100% compatible with perl/tk syntax. All changes have been
> > checked in at http://code.google.com/p/perl-tcltk
>
> Hi John,
>
> I very much glad for the much work you've done, especially if you got full
> or almost-full compatibility.
>
> What I am currently not understanding with your version - is what files are
> and what are they came from.
>
> Many perl/Tk-derived files together in same directory with Tcl::Tk files
> will produce a mess.
>
> For example in Configure.pm I see
> =========
> package Tcl::Tk::Configure;
> use vars qw($VERSION);
> $VERSION = '4.008'; # $Id: //depot/Tkutf8/Tk/Configure.pm#8 $
> ....
> =========
> This 4.008 is obviously poorly updated version in perl/Tk land, which is
> okay with me, but is it possible to invent a way to place all those files
> into their directory?
> Especially all these xbm, xpm and gif files
> If perl/Tk and Tcl::tk files are distinguished, it will be easier to check
> for updates from perl/Tk also.
>

As you found, the versions of all the .pm files should be cleaned up. This
was something I had overlooked. Some of these versions are left over from
the perl/tk version. Probably should make all of them match the main version
of the Tcl::Tk package.

I put the bitmap files (i.e. the xbm, xpm, etc files) in the Tcl/Tk
directory, because perl/tk puts them in a similar place. Bitmap files for
perl/tk end up in the Tk directory after installation. They could possibly
be moved to a bitmaps directory under the Tcl/Tk directory, as long a
Tcl::Tk->findINC can still find them.

I not sure if the perl/tk files can be separated out from the Tcl::Tk files.
Most aren't direct copies of the perl/tk files. The perl/tk files were used
as a starting point, and then hand-edited to get to work with Tcl::Tk.

If we separated out the perl/tk files, it could cause some confusion in
converting from perl/tk code to Tcl::Tk. For example, the Font.pm package is
currently in the Tcl/Tk directory, so it gets used with a "use
Tcl::Tk::Font", which is very similar to the perl/tk sytax of "use
Tk::Font". If the Font.pm package was moved to another directory (like
"Tcl/Tk/perltk"), then you would have to use "use Tcl::Tk::perltk::Font".

Maybe a better way of identifying the perl/tk files would be to put a
special text header in them (e.g. "#### Imported from perl/tk ###'), that
way you could grep for some special text, and get a list of perl/tk-derived
files.



>
> Also, what the "mktransgif.tcl" file for? Its not even in the Manifest.
>
>
It doesn't do anything. Some overactive copy/paste on my part :) . I just
removed it from svn.



> And, IMO, all versions of all files should be better thought. I see that
> Tcl::Tk version didn't change, and Tcl::Tk::Widget does not have version at
> all.
>

Agreed. All .pm files need a version. Same as the version of the overall
Tcl::Tk package IMO. Alternatively,  a version number derived from svn.

Thanks for your comments

-John