Re: [rt.cpan.org #125577] Memory loss : the perl memory for a sub {...} never gets freed.
[email protected] (huck) Tue, 07 Aug 2018 02:42:43 -0500
| Newsgroups | perl.tcltk |
|---|---|
| Message-ID | <[email protected]> |
At 01:23 AM 8/7/2018, you wrote: ><URL: https://rt.cpan.org/Ticket/Display.html?id=125577 > > >If your goal is to make a pull request to the Tcl.pm git repository >(the one on >GitHub), that's something that has to be done at least partly from a web >browser; it can't be done completely from the command line. You have to fork >the repository on GitHub, and have the clone on your computer know >of your fork >as a remote; then you can push your commit to your fork, and open a pull >request from a browser. > >This seems to be a good overview of the process (see steps "Creating a fork", >"Doing your work", and "Submitting a pull request"): >https://gist.github.com/Chaser324/ce0505fbed06b947d962 > >Or the official help: https://help.github.com/articles/fork-a-repo/ and >https://help.github.com/articles/creating-a-pull-request-from-a-fork/ > >Or, if you'd like, someone can apply the patch and/or open a PR on your behalf >(you still get credit for authoring the work in the commit). > >Hope this helps i did realize my terminology was a bit off, but i never intended to make a github account. I had always planned to do it on only my local machines and submit a patch file, but i did not realize the patch file method was not considered a "pull" at first. This is the process i used for my last patch file. # clone orig and lock down at a point # so i could restart the working copy at the same point cd ~/cvs/gits/github rm -rf ~/cvs/gits/github/tcl.pm git clone https://github.com/gisle/tcl.pm.git cd ~/cvs/gits/github/tcl.pm git checkout origin # make working copy cd ~/cvs/gits/tcl-tk rm -rf ~/cvs/gits/tcl-tk/tcl.pm git clone "file:///home/huck/cvs/gits/github/tcl.pm" cd ~/cvs/gits/tcl-tk/tcl.pm git checkout -b doc1.16 e926aa6ea07298dbc1f1dda94c5943ecc5eda4ab ### make changes vi Tcl.pm # test changes perl Makefile.PL make make test # lock down changes git commit -m 'typo fix and rname/current_r to descrname' Tcl.pm # apply to main branch git checkout master git merge -m 'doc/typo fix and rname/current_r to descrname' doc1.16 perl Makefile.PL make make test # make patch git format-patch --stdout -1 > ~/cvs/pmlib-linkpatch/doc1.16.patch cvs commit -m '' doc1.16.patch # test patch against newest master cd ~/cvs/gits/github rm -rf ~/cvs/gits/github/strp-tcl git clone https://github.com/gisle/tcl.pm.git strp-tcl cd ~/cvs/gits/github/strp-tcl git checkout master git am ~/cvs/pmlib-linkpatch/doc1.16.patch perl Makefile.PL make make test I ran the "test patch" procedure on ubuntu 12.04, 14.04, 16.04 and 18.04 boxes just to make sure. for my first patches i tested via a more complicated testing procedure shown at https://rt.cpan.org/Public/Bug/Display.html?id=125472#txn-1791081 but while it showed the added branches in gitk, the result to the master line was the same as just running the 'git am' commands against the master. Thank you for the pointers but by the time i had submitted the patches i had already digested all that material and more and realized that submitting the patch files was not considered a pull, but like i opened with i never had any thought of opening a online git account anywhere, nor did i ever plan on making my repository net accessible. At the beginning i was just confused that submitting patch files was not considered a "pull"