Re: [patch@35050] replace pathify_dirspec in VMS with new version
[email protected] ("John E. Malmberg")
| Newsgroups | perl.perl5.porters,perl.vmsperl |
|---|---|
| Message-ID | <[email protected]> |
Nicholas Clark wrote: > On Sun, Dec 07, 2008 at 08:46:52AM -0600, John E. Malmberg wrote: > > >>An additional note, this patch may cause some tests in vmsfspec.t to >>fail. That is because the old behavior of pathfiy_dirspec() was >>inconsistent with vmsify(). > > > On Sun, Dec 07, 2008 at 10:15:39AM -0600, John E. Malmberg wrote: > > >>This is all needed for me to proceed with the testing of VMS perl in a >>UNIX compatible mode. Currently most of the tests are passing. > > > My view (and on matters VMS specific I'm going to defer to Craig, if he > differs) is that if a needed change temporarily makes a known subset of > tests fail, then it should include a patch to make exactly those tests > TODO tests. Point taken, Attached is vms/ext/filespec.t that changes those tests to be passing. A more complete version will come once I make sure that everything is ok in the UNIX and extended file system support. -John [email protected] Personal Opinion Only
filespec_t.gdiff
(text/plain, 1.2 KB)
--- /rsync_root/perl/vms/ext/filespec.t Thu Mar 15 20:43:30 2007 +++ /ref1_root/perl/vms/ext/filespec.t Sun Dec 7 12:35:53 2008 @@ -100,14 +100,14 @@ __down_:[__the_.__garden_]__path_ pathify __down_:[__the_.__garden_.__path_] __down_:[__the_.__garden_]__path_. pathify # N.B. trailing . ==> null type __down_:[__the_]__garden_.__path_ pathify undef -/__down_/__the_/__garden_/__path_. pathify # N.B. trailing . ==> null type -/__down_/__the_/__garden_.__path_ pathify undef +/__down_/__the_/__garden_/__path_. pathify /__down_/__the_/__garden_/__path__/ +/__down_/__the_/__garden_.__path_ pathify /__down_/__the_/__garden____path_/ __down_:[__the_.__garden_]__path_.dir;2 pathify #N.B. ;2 __path_ pathify __path_/ /__down_/__the_/__garden_/. pathify /__down_/__the_/__garden_/./ /__down_/__the_/__garden_/.. pathify /__down_/__the_/__garden_/../ /__down_/__the_/__garden_/... pathify /__down_/__the_/__garden_/.../ -__path_.notdir pathify undef +__path_.notdir pathify __path__notdir/ # Both VMS/Unix and file/path conversions __down_:[__the_.__garden_]__path_.dir;1 unixpath /__down_/__the_/__garden_/__path_/