Re: [patch@35055] vms.c rmsexpand refactor

Craig A. Berry wrote:
> On Jan 2, 2009, at 10:14 AM, John Malmberg wrote:
> 
>> Craig A. Berry wrote:
>>>
>> How about I submit a patch that does the whitespace changes only as a 
>> first step with no other bug fixes?
> 
> If you can do that, isn't it just as easy to submit a patch that doesn't 
> mess with the existing indentation?

I can try that, now that I have identified most of the changes.

  A lot of people do, but since everyone puts their tab stops in different
> places, that generally leads to mayhem if anyone else wants to read your 
> code in a different editor and/or with different settings.  The standard 
> described in perlstyle.pod is to use 4-column indents with spaces, not 
> tabs, but preserving the existing indent style trumps that as long as 
> what's already there is done consistently.  The code you are working on 
> uses 2-column indent with considerable consistency except where tabs 
> have snuck in here and there from various patches.  IMO whatever gain 
> there might be from changing the indent style does not offset the loss 
> from not being able to easily see what's changed.

In some cases indents were missing, or the entire if/while statement was 
on one line where it was not obvious that it did not start a block.

As a result it is hard to follow reading the code.

Sooner or later, I think we should cleanup the structure.  But the 
cleanup should be a separate check in from the functional changes.

-John
[email protected]
Personal Opinion Only