Re: [blead-498-gb94a8c4] vms chdir/chmod/mkdir... thread contextdependency removal

On Feb 5, 2009, at 6:50 PM, John Malmberg wrote:

> Craig A. Berry wrote:
>> On Feb 4, 2009, at 8:43 AM, John Malmberg wrote:
>>>
>>> +  ret = Perl_flex_lstat(NULL, file_spec, &st);
>> You're explicitly passing a null thread context?  That won't work.   
>> The function prototype is
>> int     Perl_flex_lstat (pTHX_ const char *, Stat_t *);
>> and pTHX_ will not expand to anything in the case of a Perl built  
>> without thread support.  So in a non-threaded Perl you'll be  
>> passing three arguments to a function that expects two.  What  
>> problem are you trying to solve by ignoring whatever actual thread  
>> context there may be and saying that it's always null?
>
> The next patch would have covered that

I think a patch that would cause the default configuration to have  
compile failures needs to be considered not quite finished yet.

> as would remove the thread context from the wrappers and static  
> routines that do not need it.

If you're talking about routines prefixed with "Perl_" that's really  
considered a public interface and shouldn't be changed on a whim.   
Didn't you create some internal routines specifically for the cases  
where we don't or can't use a thread context?

> I do not know why the patch would not apply though.
>
> I will revise and resubmit with the changes to vmsish.h to remove  
> the thread context.  It will probably take a few days.


Great, thanks.
________________________________________
Craig A. Berry
mailto:[email protected]

"... getting out of a sonnet is much more
  difficult than getting in."
                  Brad Leithauser