Re: [PR] Force libuuid usage for IBM i (os400). [apr ]

notroj commented on code in PR #67:
URL: https://github.com/apache/apr/pull/67#discussion_r2260145767


##########
configure.in:
##########
@@ -2912,19 +2912,30 @@ dnl ----------------------------- Checking for UUID Support
 AC_MSG_NOTICE([])
 AC_MSG_NOTICE([Checking for OS UUID Support...])
 
-AC_CHECK_HEADERS(uuid.h uuid/uuid.h sys/uuid.h, break)
+if [[[ "$host" != *os400 ]]]; then

Review Comment:
   Should be done in the hints.



##########
configure.in:
##########
@@ -2912,19 +2912,30 @@ dnl ----------------------------- Checking for UUID Support
 AC_MSG_NOTICE([])
 AC_MSG_NOTICE([Checking for OS UUID Support...])
 
-AC_CHECK_HEADERS(uuid.h uuid/uuid.h sys/uuid.h, break)
+if [[[ "$host" != *os400 ]]]; then
+    AC_CHECK_HEADERS(uuid.h uuid/uuid.h sys/uuid.h, break)
+else
+    AC_CHECK_HEADERS(uuid/uuid.h, break)
+fi
 
 apr_revert_save_LIBS=$LIBS
 
 # Prefer the flavor(s) that live in libc;
 AC_SEARCH_LIBS(uuid_create, uuid)
 AC_SEARCH_LIBS(uuid_generate, uuid)
+if [[[ "$host" == *os400 ]]]; then
+    ac_cv_search_uuid_create="no"
+fi
 if test "$ac_cv_search_uuid_create" = "none required" -o \
         "$ac_cv_search_uuid_generate" = "none required"; then
  LIBS=$apr_revert_save_LIBS
 fi
-
-AC_CHECK_FUNCS(uuid_create uuid_generate)
+if [[[ "$host" != *os400 ]]]; then
+    AC_CHECK_FUNCS(uuid_create uuid_generate)
+else
+   AC_CHECK_FUNCS(uuid_generate)
+   ac_cv_func_uuid_create="no"

Review Comment:
   This should be done in the hints as well.
   
   Setting `ac_cv_func_uuid_create="no"` there is a way to predetermine the result of the test and is better than  sprinkling platform-specific hacks through the rest of the code. Same for the other cases here.
   



##########
configure.in:
##########
@@ -2912,19 +2912,30 @@ dnl ----------------------------- Checking for UUID Support
 AC_MSG_NOTICE([])
 AC_MSG_NOTICE([Checking for OS UUID Support...])
 
-AC_CHECK_HEADERS(uuid.h uuid/uuid.h sys/uuid.h, break)
+if [[[ "$host" != *os400 ]]]; then
+    AC_CHECK_HEADERS(uuid.h uuid/uuid.h sys/uuid.h, break)
+else
+    AC_CHECK_HEADERS(uuid/uuid.h, break)
+fi
 
 apr_revert_save_LIBS=$LIBS
 
 # Prefer the flavor(s) that live in libc;
 AC_SEARCH_LIBS(uuid_create, uuid)
 AC_SEARCH_LIBS(uuid_generate, uuid)
+if [[[ "$host" == *os400 ]]]; then
+    ac_cv_search_uuid_create="no"

Review Comment:
   Should be done in the hints.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]