Re: [PR] Force libuuid usage for IBM i (os400). [apr ]

brainy (via GitHub) <[email protected]> Thu, 07 Aug 2025 13:31:03 -0000
Newsgroups gmane.comp.apache.apr.devel
Message-ID <PR_kwDOAAJ05c6cYOim-2ba85c7c-3e38-4fef-bce4-2a3d9347055c@gitbox.apache.org>
brainy commented on code in PR #67:
URL: https://github.com/apache/apr/pull/67#discussion_r2260350489


##########
configure.in:
##########
@@ -2912,19 +2912,30 @@ dnl ----------------------------- Checking for UUID Support
 AC_MSG_NOTICE([])
 AC_MSG_NOTICE([Checking for OS UUID Support...])
 
-AC_CHECK_HEADERS(uuid.h uuid/uuid.h sys/uuid.h, break)
+if [[[ "$host" != *os400 ]]]; then

Review Comment:
   Also, please avoid bashisms. `[[ ... ]]` is not a standard shell test, `[ ... ]` is. Not every shell in the world is bash.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]