Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

Philip M. Gollucci wrote:
> Randy Kobes wrote:
>> [Thu Jul 20 23:45:45 2006] [error] [client 127.0.0.1]
>> (OS 80)The file exists.  :
>>  apreq_brigade_concat failed; TempDir problem?
>>
>> which is coming from about line 288 of
>> module/apache2/filter.c. The "file exists" message
>> I think comes from the fact that, when the test
>> fails, there's old temp files left over from
>> a previous run. So perhaps the cleanup discussed
>> in library/util.c at around line 797 is failing
>> occasionally?
You are absolutely correct. I can force duplicate on FBSD.
I changed this (dropped the XXXX) so I could predict the temp file name
and yanked out all the tests not for tempname in t/apreq/upload.t

  rc = apr_filepath_merge(&tmpl, path, "apreq",
                            APR_FILEPATH_NOTRELATIVE, pool);

touch /tmp/apreq

t/error_log
[Fri Jul 21 04:02:42 2006] [error] [client 127.0.0.1] $param->upload_tempname($req): can't make spool bucket at
/usr/home/pgollucci/dev/repos/asf/httpd/apreq/trunk/glue/perl/t/response/TestApReq/upload.pm line 33.

Which means
  apr_pool_cleanup_register(pool, data,
                              apreq_file_cleanup, apreq_file_cleanup);

which calls apr_file_remove() which on Win32 is way out of my league :(
I'm guessing this is failing, but silently..... or less likely the cleanup is just not being run ?

Question, are you both ASCII or UNICODE ?


-- 
------------------------------------------------------------------------
Philip M. Gollucci ([email protected]) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."