Re: [RELEASE CANDIDATE] libapreq2 2.08-RC4

Philip M. Gollucci wrote:
> Philip M. Gollucci wrote:
>> Randy Kobes wrote:
> Which means
>   apr_pool_cleanup_register(pool, data,
>                               apreq_file_cleanup, apreq_file_cleanup);
> 
Contrary to the comment in library/util.c
 data = apr_palloc(pool, sizeof *data);
    /* cleanups are LIFO, so this one will run just after
       the cleanup set by mktemp */
    apr_pool_cleanup_register(pool, data,
                              apreq_file_cleanup, apreq_file_cleanup);

    rc = apr_file_mktemp(fp, tmpl, /* NO APR_DELONCLOSE! see comment above */
                           APR_CREATE | APR_READ | APR_WRITE
                           | APR_EXCL | APR_BINARY, pool);

Win32 doesn't have mktemp, so thats not *strictly* true.

FYI,
http://svn.apache.org/viewvc/apr/apr/trunk/file_io/unix/mktemp.c?r1=62405&r2=62404&pathrev=62405

The cleanup on Win32 was removed from apr here... I'll bet that's it!


-- 
------------------------------------------------------------------------
Philip M. Gollucci ([email protected]) 323.219.4708
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Software Engineer - TicketMaster - http://ticketmaster.com
1024D/A79997FA F357 0FDD 2301 6296 690F  6A47 D55A 7172 A799 97F

"In all that I've done wrong I know I must have done something right to
deserve a hug every morning and butterfly kisses at night."