Re: Seeking a review on #69640
Eric Covener <[email protected]>
| Newsgroups | gmane.comp.apache.documentation |
|---|---|
| Message-ID | <CALK=YjPo1phg_LzmPAfAAHO6C8-bg7jFSWQkGxKoWmSufr4RyA@mail.gmail.com> |
Should have replied-all On Tue, Feb 3, 2026 at 9:42 PM Eric Covener <[email protected]> wrote: > > On Tue, Feb 3, 2026 at 8:52 PM Andrew Lyons <[email protected]> wrote: >> >> Hi folks, >> >> I raised this bug against the documentation 10 month ago and provided a patch at the time. Unfortunately it is still in the "NEW" status, and has had no review or oversight at all. >> >> What can I do to help get this change processed? I've read through all of the guidance on the docs project and have previously posted on these mailing lists. > > > Hi, my 2c only -- I don't think we should update anything but the mod_dir doc here. > > diff --git a/docs/manual/mod/mod_dir.xml b/docs/manual/mod/mod_dir.xml > index ac826d4647..3a8081deb1 100644 > --- a/docs/manual/mod/mod_dir.xml > +++ b/docs/manual/mod/mod_dir.xml > @@ -238,7 +238,7 @@ a directory</description> > </directivesynopsis> > <directivesynopsis> > <name>FallbackResource</name> > -<description>Define a default URL for requests that don't map to a file</description> > +<description>Define a default URL for requests that don't map to a file, or handler</description> > <syntax>FallbackResource disabled | <var>local-url</var></syntax> > <default>disabled - httpd will return 404 (Not Found)</default> > <contextlist><context>server config</context><context>virtual host</context> > @@ -247,8 +247,9 @@ a directory</description> > <compatibility>The <code>disabled</code> argument is available in version 2.4.4 and > later</compatibility> > <usage> > - <p>Use this to set a handler for any URL that doesn't map to anything > - in your filesystem, and would otherwise return HTTP 404 (Not Found). > + <p>Use this to set a handler for any URL that doesn't map to any > > If we are clarifying the relationship to "handlers" here we should avoid calling the argument a handler. > > > + <note><title>Note</title> > + <p>When directives such as <directive>AddHandler</directive>, and > + <directive>SetHandler</directive> are applied unconditionally, the > + <directive>FallbackResource</directive> will have no effect.</p> > > + </note> > > The same is true of when it's set conditionally > > -/- > > > I went through and cleaned it up from top-to-bottom, plus the moral of your update, what do you think about the below? > > https://gist.github.com/covener/3d308b5042c139c2d02ae6c4f4565d17 -- Eric Covener [email protected]