Confirmed new bug, CONTINUE+REDIRECT

The release candidate contains a minor flaw causing CONTINUE + REDIRECT to
work in an incorrect manner. For example, if we have a file called
"person.survey", this will fail:

  <SURVEY TITLE="Person" CONTINUE="person.survey?action=data" 
     REDIRECT="yes" ...>

.. because the REDIRECT code will automatically add arguments to the GET 
string, in practise a session id and "?action=display". Thus it is 
currently not possible to automatically direct the user to the display of 
data after data submission. 

The behaviour is faulty since the addition to the GET string should only 
take place if CONTINUE and REDIRECT have been implied by a *ROUTE tag, not 
when CONTINUE and REDIRECT have been set explicitly. 

If REDIRECT is not explicitly set, the bug does not appear. 

Redirecting to any URL which does not consider the arguments in the GET 
string shouldn't be any problem. Further, I cannot see that the bug should 
have any security implications. 

As I'm off for my brother's wedding soon, I won't fix this until in a week 
or so. So if anyone feels up to coding a bit, the correct place to take a 
look at (to, for example, add an if statement) is in Submit.pm, the 
SubmitMsg() sub, lines 167 to 178. :-)

  // Joel
Skickat av Joel Palmius <[email protected]>
till survey-discussion