$status calling print_to_server_and_die

Chapman Flack <[email protected]> Tue, 5 Dec 2017 17:42:50 -0500
Newsgroups gmane.comp.archivers.amanda.devel
Message-ID <[email protected]>
Hi,

I notice there are comments above Script_App::print_to_server
and print_to_server_and_die saying the status should be GOOD
or ERROR. But I see that FAILURE is also an option ... in fact,
since 3.3.8, print_to_server_and_die always forces the status
to FAILURE anyway.

Should those comments really say GOOD, ERROR, or FAILURE ?

I made Application::Abstract and Script::Abstract to pass ERROR
to print_to_server_and_die (because of the comment), but I might
prefer to pass FAILURE explicitly, so they produce the right
output even if backported into a pre-3.3.8 Amanda version.

-Chap