Re: $status calling print_to_server_and_die
Jean-Louis Martineau <[email protected]> Wed, 6 Dec 2017 07:43:42 -0500
| Newsgroups | gmane.comp.archivers.amanda.devel |
|---|---|
| Message-ID | <[email protected]> |
On 05/12/17 05:42 PM, Chapman Flack wrote: > Hi, > > I notice there are comments above Script_App::print_to_server > and print_to_server_and_die saying the status should be GOOD > or ERROR. But I see that FAILURE is also an option ... in fact, > since 3.3.8, print_to_server_and_die always forces the status > to FAILURE anyway. > > Should those comments really say GOOD, ERROR, or FAILURE ? yes > > I made Application::Abstract and Script::Abstract to pass ERROR > to print_to_server_and_die (because of the comment), but I might > prefer to pass FAILURE explicitly, so they produce the right > output even if backported into a pre-3.3.8 Amanda version. You can. Jean-Louis This message is the property of CARBONITE, INC. and may contain confidential or privileged information. If this message has been delivered to you by mistake, then do not copy or deliver this message to anyone. Instead, destroy it and notify me by reply e-mail