Re: diff segfaults with 2009-01-05

Lasse Kliemann <[email protected]> wrote:

> Using schily-dist pre5 and gcc 4.1.2 on Linux 2.6.27.21.
>
> $ smake COPTX=3D-O0 CFLAGS=3D-O0
>
> $ ./star/OBJ/i686-linux-cc/star -version
> star: star 1.5 (i686-pc-linux-gnu)
> Options: find fflags remote
>
> $ ./star/OBJ/i686-linux-cc/star -c -diff -C a b c
> Segmentation fault
>
> It's the same with several other recent versions.

Thank you for the report, please apply this patch:


------- buffer.c -------
--- /tmp/sccs.ziaqjg	Do Apr 23 14:24:48 2009
+++ buffer.c	Do Apr 23 14:13:44 2009
@@ -319,7 +319,7 @@
 			}
 		}
 	}
-	if (isatty(fdown(tarf)))
+	if (tarf !=3D (FILE *)NULL && isatty(fdown(tarf)))
 		comerrno(EX_BAD, "Archive cannot be a tty.\n");
 	if (!isremote && (!nullout || (uflag || rflag)) &&
 	    tarf !=3D (FILE *)NULL) {


J=F6rg

-- =

 EMail:[email protected] (home) J=F6rg Schilling D-13353 Be=
rlin
       [email protected]                (uni)  =

       [email protected] (work) Blog: http://schily.blogs=
pot.com/
 URL:  http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily