Re: diff segfaults with 2009-01-05

--===============1777574830==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="dXvu6+ixFx2ZffE8"
Content-Disposition: inline


--dXvu6+ixFx2ZffE8
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Message by -Joerg Schilling- from Thu 2009-04-23:
> Lasse Kliemann <[email protected]> wrote:
>=20
> > Using schily-dist pre5 and gcc 4.1.2 on Linux 2.6.27.21.
> >
> > $ smake COPTX=3D-O0 CFLAGS=3D-O0
> >
> > $ ./star/OBJ/i686-linux-cc/star -version
> > star: star 1.5 (i686-pc-linux-gnu)
> > Options: find fflags remote
> >
> > $ ./star/OBJ/i686-linux-cc/star -c -diff -C a b c
> > Segmentation fault
> >
> > It's the same with several other recent versions.
>=20
> Thank you for the report, please apply this patch:
>=20
>=20
> ------- buffer.c -------
> --- /tmp/sccs.ziaqjg	Do Apr 23 14:24:48 2009
> +++ buffer.c	Do Apr 23 14:13:44 2009
> @@ -319,7 +319,7 @@
>  			}
>  		}
>  	}
> -	if (isatty(fdown(tarf)))
> +	if (tarf !=3D (FILE *)NULL && isatty(fdown(tarf)))
>  		comerrno(EX_BAD, "Archive cannot be a tty.\n");
>  	if (!isremote && (!nullout || (uflag || rflag)) &&
>  	    tarf !=3D (FILE *)NULL) {

This patch (applied to star/buffer.c in pre5) makes the problem=20
go away.

Thanks for the fix.

--dXvu6+ixFx2ZffE8
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iQIcBAEBAgAGBQJJ8K0lAAoJEFYll6N4nhdvIwkQAN2DPb6V9FW5CCZoVUFhhXWU
GciBNoNnFvsgRNZy45f9Mm9n9hh6C5C0nCIaeRxEwtKBRNAOSTGRd7JNfCUSwpS+
8EbrmG18zZWJ24OKelBS8pki30l9FWUUPLThNbC7yIvI4c22pK0t1EcHy6qtro3L
CSSZboasZf45f7cNuEUH1vxM+YDVkRqwS3eJlIG3PTdS79oxc9WOMH703twXghw+
JQOFDjSyai/y7Vtn9jf8mGWzqt1Iy4DF8hyA9ZywYpXpg6mf7X7BfmGf4DUnOm9O
MAbvySv0u4/mVUE16V+FYRdgLmBzydul41BT7DQoSh895BxnfcFZ3oXAF1mMvawX
UIwRivyr2aF7+8DRHKUHS51Tk0cyhTVjduUm2zAzmp2iAemae3AYIrK5Hsk81rh9
ho0qUZnjmI8pjqTC3xeAmORMT75M7q+QITU63l7pMa6tY57uWWceYWBXxoNK81zJ
VLPDhFSulVXT/oIY9hquAL6sUWg29f5LBvib96/wQ1G5kjk4rpOK5Kkr5Mn5kkGl
tO1Rv96Yvir8wEGO7RrtJN7ox0HdgUOvGuC+J2V4DlQP1bulE18Rc+62X+cBmkqs
XtQzTtC5mWS9R/d1aI8mkfTaHQn+UKnfYhIkta4wYrVpWaecaJZFROwr5kc4nzLo
qh4qzfeb7N1xTboVqgy4
=g3Mf
-----END PGP SIGNATURE-----

--dXvu6+ixFx2ZffE8--

--===============1777574830==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Star-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/star-users

--===============1777574830==--