Re: error in files after removing padding

Scott Brown <[email protected]> Mon, 19 May 2014 10:14:47 -0400
Newsgroups gmane.comp.audio.compression.flac.user
Message-ID <CANJq19JhqffmJ5bsBLaxtNtJbQhPufwC5sw1oa3Hh4fa+rZLRw@mail.gmail.com>
--===============1912617882==
Content-Type: multipart/alternative; boundary=20cf307cffaaee6e7d04f9c16344

--20cf307cffaaee6e7d04f9c16344
Content-Type: text/plain; charset=UTF-8

I thought I ran it on a fresh file, but I just double checked and I must
have run it on a stripped file earlier because I don't get the error now on
an un-stripped file. I suppose it is an issue with TagLib?

Would you still be curious to see one of the "bad" files?

Thanks,
Scott


On Mon, May 19, 2014 at 10:06 AM, Martijn van Beurden <[email protected]>wrote:

>  Oh, I forgot to tell (but you probably had that figured out anyway) that
> those 2 steps were for a file that you didn't strip of padding before.
>
> Would it be possible you send me a part of a file that is affected? I'd
> like to know what happened, so this can be fixed. I presume the
> FLAC__STREAM_DECODER_END_OF_STREAM errors occur right after the album art?
> In that case, if the files are too big and you are using linux you could
> use head -c 500kB input.flac > input-first500kb.flac I don't know any
> equivalent methods on other operating systems. If the included album art is
> bigger than 500kb, you might want to change the numbers accordingly.
>
> op 19-05-14 15:56, Scott Brown schreef:
>
> Thanks for the help Martijn,
>
>  I get the same FLAC__STREAM_DECODER_END_OF_STREAM error after doing the
> 2 steps you suggested.
>
>  Scott
>
>
> On Mon, May 19, 2014 at 9:36 AM, Martijn van Beurden <[email protected]>wrote:
>
>>  Once more hi,
>>
>> I've tried to reproduce this issue, but I am unable to do so. Could you
>> try to re-encode the file with FLAC (to make sure it is not an issue with
>> Taglib) and try to strip with metaflac again? This can be done as follows
>>
>> flac input.flac -o output.flac
>> metaflac --dont-use-padding --remove --block-type=PADDING output.flac
>>
>> If this turns out to be fine it probably solves your problem, but still I
>> would be interested in a file to check whether Taglib produces
>> non-compliant files or metaflac doesn't accept all valid input. If it turns
>> out that metaflac doesn't like this either, there is something rather weird
>> going on.
>>
>>
>> op 19-05-14 15:21, Scott Brown schreef:
>>
>>  ERROR while decoding data
>>                     state = FLAC__STREAM_DECODER_END_OF_STREAM
>>
>>  It's happening with every file that I've tried now, using both 1.2.1
>> and 1.3.0.
>>
>>  If a file has artwork and I remove padding, I get the above error when
>> verifying or decompressing. If no artwork and I remove padding, the file
>> verifies and decompresses with no issues.
>>
>>  I'm writing tags via Taglib's file.save() but removing padding via
>> metaflac.
>>
>>  Thanks,
>> Scott
>>
>>
>> On Mon, May 19, 2014 at 9:16 AM, Martijn van Beurden <[email protected]>wrote:
>>
>>>  Hi Scott,
>>>
>>> Can you be a little more specific? What error do you get? I'm unable to
>>> reproduce this error currently, do you have any files you can share that
>>> are problematic? What version of metaflac are you using?
>>>
>>> It might be a bug, it might be corruption induced by some other part of
>>> the system.
>>>
>>> op 19-05-14 15:04, Scott Brown schreef:
>>>
>>>  I want to remove padding from flac files, so I ran the following
>>> command on files with artwork in them:
>>>
>>>  metaflac --dont-use-padding --remove --block-type=PADDING [filename]
>>>
>>>
>>>   but now my files are corrupt. Verifying them reports a stream error
>>> and they won't decode.
>>>
>>>  If the files had no picture data in them, the remove padding command
>>> did not corrupt them.
>>>
>>>  Is this a bug, or did I run something bad with metaflac?
>>>
>>>  Thanks,
>>> Scott
>>>
>>>
>>>  _______________________________________________
>>> Flac mailing [email protected]://lists.xiph.org/mailman/listinfo/flac
>>>
>>>
>>>
>>> _______________________________________________
>>> Flac mailing list
>>> [email protected]
>>> http://lists.xiph.org/mailman/listinfo/flac
>>>
>>>
>>
>>
>> _______________________________________________
>> Flac mailing list
>> [email protected]
>> http://lists.xiph.org/mailman/listinfo/flac
>>
>>
>
>

--20cf307cffaaee6e7d04f9c16344
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>I thought I ran it on a fresh file, but I just double=
 checked and I must have run it on a stripped file earlier because I don&#3=
9;t get the error now on an un-stripped file. I suppose it is an issue with=
 TagLib?<br>

<br>Would you still be curious to see one of the &quot;bad&quot; files?<br>=
<br></div>Thanks,<br>Scott<br></div><div class=3D"gmail_extra"><br><br><div=
 class=3D"gmail_quote">On Mon, May 19, 2014 at 10:06 AM, Martijn van Beurde=
n <span dir=3D"ltr">&lt;<a href=3D"mailto:[email protected]" target=3D"_blan=
k">[email protected]</a>&gt;</span> wrote:<br>

<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
 =20
   =20
 =20
  <div bgcolor=3D"#FFFFFF" text=3D"#000000">
    Oh, I forgot to tell (but you probably had that figured out anyway)
    that those 2 steps were for a file that you didn&#39;t strip of padding
    before.<br>
    <br>
    Would it be possible you send me a part of a file that is affected?
    I&#39;d like to know what happened, so this can be fixed. I presume the
    FLAC__STREAM_DECODER_END_OF_STREAM errors occur right after the
    album art? In that case, if the files are too big and you are using
    linux you could use head -c 500kB input.flac &gt;
    input-first500kb.flac I don&#39;t know any equivalent methods on other
    operating systems. If the included album art is bigger than 500kb,
    you might want to change the numbers accordingly.<br>
    <br>
    <div>op 19-05-14 15:56, Scott Brown schreef:<br>
    </div><div><div class=3D"h5">
    <blockquote type=3D"cite">
      <div dir=3D"ltr">Thanks for the help Martijn,
        <div><br>
        </div>
        <div>I get the same=C2=A0<span style=3D"font-family:arial,sans-seri=
f;font-size:13px">FLAC__STREAM_DECODER_END_OF_</span><font face=3D"arial, s=
ans-serif">STREAM error after=C2=A0doing the 2
            steps you suggested.</font><br>
        </div>
        <div><font face=3D"arial, sans-serif"><br>
          </font></div>
        <div><font face=3D"arial, sans-serif">Scott</font></div>
      </div>
      <div class=3D"gmail_extra"><br>
        <br>
        <div class=3D"gmail_quote">On Mon, May 19, 2014 at 9:36 AM,
          Martijn van Beurden <span dir=3D"ltr">&lt;<a href=3D"mailto:mvanb=
[email protected]" target=3D"_blank">[email protected]</a>&gt;</span> wrote:<br>
          <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bord=
er-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor=3D"#FFFFFF" text=3D"#000000"> Once more hi,<br>
              <br>
              I&#39;ve tried to reproduce this issue, but I am unable to do
              so. Could you try to re-encode the file with FLAC (to make
              sure it is not an issue with Taglib) and try to strip with
              metaflac again? This can be done as follows<br>
              <br>
              flac input.flac -o output.flac<br>
              metaflac --dont-use-padding --remove --block-type=3DPADDING
              output.flac<br>
              <br>
              If this turns out to be fine it probably solves your
              problem, but still I would be interested in a file to
              check whether Taglib produces non-compliant files or
              metaflac doesn&#39;t accept all valid input. If it turns out
              that metaflac doesn&#39;t like this either, there is somethin=
g
              rather weird going on.<br>
              <br>
              <br>
              <div>op 19-05-14 15:21, Scott Brown schreef:<br>
              </div>
              <div>
                <div>
                  <blockquote type=3D"cite">
                    <div dir=3D"ltr">
                      <div>ERROR while decoding data</div>
                      <div>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 =C2=A0 state =3D
                        FLAC__STREAM_DECODER_END_OF_STREAM</div>
                      <div><br>
                      </div>
                      <div>It&#39;s happening with every file that I&#39;ve
                        tried now, using both 1.2.1 and 1.3.0.</div>
                      <div><br>
                      </div>
                      <div>If a file has artwork and I remove padding, I
                        get the above error when verifying or
                        decompressing. If no artwork and I remove
                        padding, the file verifies and decompresses with
                        no issues.</div>
                      <div><br>
                      </div>
                      <div>I&#39;m writing tags via Taglib&#39;s file.save(=
) but
                        removing padding via metaflac.</div>
                      <div><br>
                      </div>
                      <div>Thanks,</div>
                      <div>Scott</div>
                      <div class=3D"gmail_extra"><br>
                        <br>
                        <div class=3D"gmail_quote">On Mon, May 19, 2014 at
                          9:16 AM, Martijn van Beurden <span dir=3D"ltr">&l=
t;<a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a=
>&gt;</span>
                          wrote:<br>
                          <blockquote class=3D"gmail_quote" style=3D"margin=
:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
                            <div bgcolor=3D"#FFFFFF" text=3D"#000000"> Hi
                              Scott,<br>
                              <br>
                              Can you be a little more specific? What
                              error do you get? I&#39;m unable to reproduce
                              this error currently, do you have any
                              files you can share that are problematic?
                              What version of metaflac are you using?<br>
                              <br>
                              It might be a bug, it might be corruption
                              induced by some other part of the system.<br>
                              <br>
                              <div>op 19-05-14 15:04, Scott Brown
                                schreef:<br>
                              </div>
                              <blockquote type=3D"cite">
                                <div>
                                  <div>
                                    <div dir=3D"ltr">I want to remove
                                      padding from flac files, so I ran
                                      the following command on files
                                      with artwork in them:
                                      <div><br>
                                      </div>
                                      <div>metaflac=C2=A0<span style=3D"col=
or:rgb(209,47,27);font-family:Menlo;font-size:11px">--dont-use-padding=C2=
=A0</span><span style=3D"color:rgb(209,47,27);font-family:Menlo;font-size:1=
1px">--remove=C2=A0</span><span style=3D"color:rgb(209,47,27);font-family:M=
enlo;font-size:11px">--block-type=3DPADDING


                                          [filename]</span></div>
                                      <div>
                                        <p style=3D"margin:0px;font-size:11=
px;font-family:Menlo;color:rgb(61,29,129)"><br>
                                        </p>
                                        <p style=3D"margin:0px;font-size:11=
px;font-family:Menlo;color:rgb(61,29,129)"><span style=3D"color:rgb(0,0,0)"=
></span></p>
                                      </div>
                                      <div>but now my files are corrupt.
                                        Verifying them reports a stream
                                        error and they won&#39;t decode.</d=
iv>
                                      <div><br>
                                      </div>
                                      <div>If the files had no picture
                                        data in them, the remove padding
                                        command did not corrupt them.</div>
                                      <div><br>
                                      </div>
                                      <div>Is this a bug, or did I run
                                        something bad with metaflac?</div>
                                      <div><br>
                                      </div>
                                      <div>Thanks,</div>
                                      <div>Scott</div>
                                    </div>
                                    <br>
                                    <fieldset></fieldset>
                                    <br>
                                  </div>
                                </div>
                                <pre>______________________________________=
_________
Flac mailing list
<a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]</a>
<a href=3D"http://lists.xiph.org/mailman/listinfo/flac" target=3D"_blank">h=
ttp://lists.xiph.org/mailman/listinfo/flac</a>
</pre>
                              </blockquote>
                              <br>
                            </div>
                            <br>
_______________________________________________<br>
                            Flac mailing list<br>
                            <a href=3D"mailto:[email protected]" target=3D"_bla=
nk">[email protected]</a><br>
                            <a href=3D"http://lists.xiph.org/mailman/listin=
fo/flac" target=3D"_blank">http://lists.xiph.org/mailman/listinfo/flac</a><=
br>
                            <br>
                          </blockquote>
                        </div>
                        <br>
                      </div>
                    </div>
                  </blockquote>
                  <br>
                </div>
              </div>
            </div>
            <br>
            _______________________________________________<br>
            Flac mailing list<br>
            <a href=3D"mailto:[email protected]" target=3D"_blank">[email protected]=
g</a><br>
            <a href=3D"http://lists.xiph.org/mailman/listinfo/flac" target=
=3D"_blank">http://lists.xiph.org/mailman/listinfo/flac</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
    </blockquote>
    <br>
  </div></div></div>

</blockquote></div><br></div>

--20cf307cffaaee6e7d04f9c16344--

--===============1912617882==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Flac mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/flac

--===============1912617882==--