version 2.3.3, file log.c bug report

David Binderman <[email protected]> Fri, 28 Jun 2013 09:22:40 +0000

Newsgroups	gmane.comp.audio.icecast.devel
Message-ID	<[email protected]>

Hello there,

I just ran the static analysis checker "cppcheck" over the source code
of icecast version 2.3.3

Amongst many other things, it said

[log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25.

Source code is

    if (log_id < 0 && log_id>= LOG_MAXLOGS)
        return;

Suggest replace && with ||.

Regards

David Binderman