Re: version 2.3.3, file log.c bug report

reflum,

On Fri, 2013-06-28 at 09:22 +0000, David Binderman wrote:
> Hello there,
> 
> I just ran the static analysis checker "cppcheck" over the source code
> of icecast version 2.3.3
> 
> Amongst many other things, it said
> 
> [log.c:301]: (warning) Logical conjunction always evaluates to false: log_id < 0 && log_id>= 25.
> 
> Source code is
> 
>     if (log_id < 0 && log_id>= LOG_MAXLOGS)
>         return;
> 
> Suggest replace && with ||.

Thanks for reporting. I just commited the change as r18961.

Have a nice day!

-- 
Philipp.
 (Rah of PH2)

_______________________________________________
Icecast-dev mailing list
[email protected]
http://lists.xiph.org/mailman/listinfo/icecast-dev

-----BEGIN PGP SIGNATURE-----
Comment: Because it's your freedom

iQEVAwUAUdVrZwHe/Le09SfmAQJlIQf/R/QmYptpuAfSyRRPqbLv7gSCkgpEK1vm
Phn7SyHqpZ7l43uUtkkq2y2NsNxmGF2hPqRH0bK+W5+52IlHFI6UMrgpPrDXb+Qw
lFy+E/ueZLtskLa2bUHj+RnIXSxIt5o6uZ6HeskCfCwNRiPYalMd0btZb5yju/hT
drLB/moraNhKecAhp+etKRwjlkXiuqvjMm/MIig1pmPL8YoPVe/wZM5kwe0peQJ/
fzS5JaXH4NP2Yh2w35Kx2Ir3UE1MrwH34jQTcfHJUupMoaUIjx/JYYphwCm+dJGV
BgtbYJkGXqQaaCiw6IQSQQWesg51ZbFmA2aHOwVYdFw39zxA+gRa0A==
=+gXQ
-----END PGP SIGNATURE-----