[patch] Replace internal mpglib with libmpg123 usage

Thomas Orgis <[email protected]> Sat, 9 Sep 2017 23:11:02 +0200
Newsgroups gmane.comp.audio.mp3.lame
Message-ID <20170909231102.291cad2f@sturbolzen>
Hello folks,

I finally am sending a first patch that replaces the internal mpg123
fork (mpglib) with usage of an updated libmpg123 covers all
functionality that I see. I tested encoding of WAV and transcoding of
MP3. I tested mp3x (remember to have -std=gnu89 in CFLAGS to be able to
build it) and the output seems to match for me. Please note that I do
think that there is something not right with mp3x cutting off the
leading frames. Isn't there cut too much? In any case, the same happens
now with mpglib and libmpg123.

To test the patch you need a current snapshot of mpg123, the upcoming
version 1.26.0, get it via

	https://mpg123.org/snapshot

. Then, something along

	CFLAGS="-g -std=gnu89 $CFLAGS" \
	PKG_CONFIG_PATH=$MPG123_PREFIX/lib/pkgconfig \
	./configure --enable-libmpg123 --enable-mp3x && make

should give you a current build with libmpg123. Naturally, I would like
people to test this a lot and tell me if something is wrong or missing.

Then we can start talking about programming style, placement of braces
and such, OK? ;-)

The patch is rather noisy since you decided to include the autotools
files in CVS. I wanted to be nice and modified the configure script
to have some logic and switches for the choice between mpg123 and
mpglib. The current state checks for a recent enough version of mpg123
and otherwise falls back to the internal mpglib.


Alrighty then,

Thomas
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot