Re: I really would like to get mpg123 with the lame-releated changes out ...
Alexander Leidinger <[email protected]> Mon, 28 May 2018 15:20:53 +0200
| Newsgroups | gmane.comp.audio.mp3.lame |
|---|---|
| Message-ID | <20180528152053.Horde.02bj41snmew11zGJ4ffPRgg@webmail.leidinger.net> |
Quoting Thomas Orgis <[email protected]> (from Sun, 27 May 2018 12:44:30 +0200): > Am Sat, 26 May 2018 21:43:59 +0200 > schrieb Fabian Greffrath <[email protected]>: > >> to me, personally, one show stopper is that the patch contains >> modifications to generated files such as the ./configure script and all >> Makefile.in files. > > I just did a cvs diff. I was wondering why those files are versioned at > all. Seemed odd. I figured that the project wants it that way and hence > changes to those files should be part of a patch. > > Well, let's try to strip that out and test things with a current > checkout from Subversion. I strongly suggest considering removal of > these auto-generated files from the repository. History (IIRC): The generated files are included in the repo so that - someone who get's a copy of the most recent versions in the repo doesn't need to have the autotools installed. - the files are generated by known good versions of the autotools. - we have a trace of what was delivered on a release (different developers may have different versions installed). Bye, Alexander. -- http://www.Leidinger.net [email protected]: PGP 0x8F31830F9F2772BF http://www.FreeBSD.org [email protected] : PGP 0x8F31830F9F2772BF ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot