Re: [patch] external MPEG audio decoding using libmpg123

Quoting Thomas Orgis <[email protected]> (from Sun, 27 May 2018  
16:34:59 +0200):

> Hi all,
>
> this is an updated version of my patch to enable use of libmpg123 from
> lame, facilitating future deprecation of the internal mpglib fork. With
> the patch, a suitable libmpg123 is detected and replaces mpglib by
> default. Configure switches override that.
>
> The necessary changes to the libmpg123 API are in mpg123 development
> trunk and I am waiting with a release until it is confirmed that the
> API additions are good for LAME use (namely, mp3x). So you need a
> procedure along this to test the patch:

[...]

> wget https://mpg123.org/test/lame-svn-r6432-libmpg123.patch

Glancing at it (mostly high-level stuff, not really looking line by  
line at C-code):
  - why do you comment out "-I\$(srcdir)"?
  - "--disable-decoder", what do you mean by "overridden by  
libmpg123"? After reading the sh-code I think you implemented "if no  
libmpg123, then internal decoder, if internal decoder disabled, then  
no decoder". Is this what we want? I thought the goal is to replace  
the internal decoder. If this means we have to get rid of  
AMIGA_MPEGA... well, personally I (as a previous Amiga owner) wouldn't  
mind. This should also make later parts more easy (e.g. get rid of the  
internal decoder files and conditionals and the Makefile.am in mpglib).
  - libmp3lame/Makefile.am: I rather prefer the math lib last; here  
you added top_srcdir again... see first item

Bye,
Alexander.


-- 
http://www.Leidinger.net [email protected]: PGP 0x8F31830F9F2772BF
http://www.FreeBSD.org    [email protected]  : PGP 0x8F31830F9F2772BF
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot