Re: Feedback required for CritiqueBrainz's Moderation Interface

On 6/28/15, Roman Tsukanov <[email protected]> wrote:

>>> We also need a way to ban/delete users.
>>
>> Considering that this action will only be taken when all the reviews
>> of a user are spam, I think we should just delete the user account
>> (which will also remove all the associated reviews.)
>
> I'm not sure if banning someone should mean that everything that this
> user wrote needs to be deleted. What if some of their reviews are not
> spam?
>
> It would also be nice to make that action reversible. In case one of
> the accounts is deleted by mistake or something else happens. Maybe
> accounts should be blocked or archived instead? Though, these users
> should still be able to delete their reviews or account completely,
> even if they can't create new reviews, vote, etc. anymore.

I thought of allowing admins to block a user account by adding a new
field 'user_type' (which could also be used for admin/moderators) but
there's already some user types defined in the constants file:
https://github.com/metabrainz/critiquebrainz/blob/master/critiquebrainz/data/constants.py#L13

I remember reading a comment from you somewhere that these user and
review classes just confuse people and should be removed, but I can't
seem to find a link for it.

Do you suggest that I should just drop these classes and make
necessary changes in the code before adding the user blocking thing?

---

dufferZafar