Re: Latest Changes

Hi Ted,

On 18/10/2022 01:20, Ted Felix wrote:
>    I've just pushed some changes to git.  Please test.

Awesome, thanks!

> 
>    Philip has made a number of improvements as a result of running 
> cppcheck.  Some general regression testing would be helpful here.

How could we test this? :-)

> 
>    I've redesigned the code for looping, both Classic and Advanced.  If 
> you are a loop user, please test both.  The behavior should be exactly 
> as before.  You will find the setting in the preferences: Advanced 
> Looping (experimental).  (I should probably bump that to beta as we will 
> be making it official and possibly the default for the 23.06 release.)
> 
>    Key addition to Advanced Looping is indicators on the loop ruler for 
> LoopOff, LoopOn, and LoopAll.  I've gone with a black/white/blue color 
> scheme to accommodate color blindness.  We could also do crosshatching 
> for LoopAll mode to eliminate the need for color altogether.  Input from 
> color blind users would be appreciated here.  E.g. is the LoopAll dark 
> blue background bright enough?
> 
>    Give it a whirl and let me know how it goes.

Seems to work fine. Just to make sure this is how it was previously 
discussed.

- Normal loop (Advanced Looping *deselected* in preferences) will loop 
the selected (light white) range e.g. selectable by doing SHIFT + 
LEFT-CLICK and drag or RIGHT-CLICK and drag, deselectable by just 
RIGHT-CLICKING without drag
- New Advanced Loop selected in preferences: Turn on/off by either SHIFT 
+ LEFT-CLICK or RIGHT-CLICK on the ruler. Will loop the whole song, i.g. 
from start to the end of the last segment

Correct?

There is a quirk for which if you turn on Advanced looping in 
preferences, activate the looping, then turn off Advanced looping in 
preferences, the looping is still active (blue color) and continues to 
loop in advenced 'mode'. This stays on until you de-activate it with a 
RIGHT-CLICK.

Also it seems the two looping modes can still co-exist but if the 
advanced looping is on then the normal range loop can only be 
activated/deactivated via the transport window because now RIGHT-CLICK 
and SHIFT + LEFT-CLICK are 'grabbed' by the advanced looping feature.

Maybe as RIGHT-CLICK and SHIFT + LEFT-CLICK seem to be funcionally the 
same if they could be differentiated.

If advanced loop is on and activated (i.e. blue) I think it's confusing 
to see the former loop range in lighter blue, as this is not used now. 
So maybe as advanced loop has the 'precedence' on normal one just make 
the whole range (up to the end of the last segment) blue (or whatever 
colour is chosen): i.e. have a visual clue on the ruler of what is 
actually being looped?

There is also now an ambiguity about what the loop button in the 
transport does when Advanced loop is on in preferences: at the moment it 
seems it still only switches normal loop on / off.
About the latter I think now we have two possible loop modes from a UX 
point of view the best would be to have two distinct buttons in the main 
toolbar (within the transport controls is usually rather idiomatic for 
sequencers) and two distinct keyboard shortcuts to toggle these on/off. 
I think it's fine for one to have 'precedence' on the other but which is 
active should always be evident.

I hope this helps and is clear let me know if you want maybe a 
walk-through and more detailed explanation of the above.

Lorenzo

> 
> Thanks.
> Ted.
> 
> 
> _______________________________________________
> Rosegarden-user mailing list
> [email protected] - use the link below to unsubscribe
> https://lists.sourceforge.net/lists/listinfo/rosegarden-user



_______________________________________________
Rosegarden-user mailing list
[email protected] - use the link below to unsubscribe
https://lists.sourceforge.net/lists/listinfo/rosegarden-user