RE: Re: music browser
"Kristian G. Kvilekval" <[email protected]>
| Newsgroups | gmane.comp.audio.zinf.devel |
|---|---|
| Message-ID | <[email protected]> |
> > >On Fri, 2003-09-19 at 07:01, David Hough wrote: > >Unfortunatley that wasn't, delete'ing that causes an immediate > >crash. I think it will be somewhere in the creation of > >cataloginfo items when the items become visible, we should only do this > the first time. > > Didn't you say that the leak was when you scrolled any list, not just > the tree? Or is the problem only in the tree? > > If its in any list then the only code that is common to all the lists is > GTKMusicList, and the only function called when a list is scrolled is > GTKMusicList::scrolledwindow_changed_visible so it must be in there > somewhere. Hmm.. I see your point. It is in the playlist, tracklist, and library tree. > If its only in the tree then it should be in > GTKLibraryTree::set_rows_data or a function called by it. However, this > shouldn't actually do anything if the row has already been displayed, as > it should only recreate the cataloginfo object (by a call to > fill_in_child) when the catalog has been changed (it checks > m_library->m_last_change, which should store the last time the catalog > has been changed). > > As for the delete TempColumn causing a crash, having checked the code > again it turns out that I have actually used TempColumn in the if > statement, so it would definitly cause a crash by deleting it before > then, oops. Moving the delete TempColumn to after the if statement will > hopefully fix that, and hopefully get the leak. If it dosen't I'm at a > complete loss, I'm afraid until I a chance to actually work on the code > again. > No the delete was after the if.. I can't seem to find any documentation in gtk nor gtkmm about get_path_at_pos(...., TreeColumn...) I see from the source that this pointer is Glib::wrap'ed, but haven't found anything about that either. -- email:[email protected] office:(805)893-4276 http://www.cs.ucsb.edu/~kris ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf