Re: Latest set of Win32 patches

On Sat, 2003-09-20 at 10:46, Tim Lesher wrote:
> On Sat, Sep 20, 2003 at 04:05:58PM +0100, David Vrabel wrote:
> > From the mkstemp(3) man page:
> > 
> >   "Don't use this function, use tmpfile(3) instead.  It is better
> >    defined and more portable."
> 
> Hmm... doesn't say that in my set of man pages.
> 
> Anyway, in general I _would_ rather use tmpfile than mkstemp for
> exactly this reason--tmpfile is defined on Win32.  (In fact, I think I
> changed at least one mkstemp to tmpfile elsewhere in zinf.)  
> 
> The problem is that where mkstemp is used in vorbis, the file is
> closed and then used later--not possible with tmpfile, because tmpfile
> deletes the file on close.  The code can probably be rewritten not to
> need this behavior; I'll keep that in mind.


We could solve this also by doing away with using a temporary file
completely.   Only the name is temporary while the original
file is copied with the new tags included.

We could use something like

  oggfilenmae.ogg -> oggfilename.ogg.new

and rename it back once the comments are written out.




-- 
email:[email protected] office:(805)893-4276 http://www.cs.ucsb.edu/~kris



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf