Re: 2.2.4 release soon?

Andreas Rottmann writes:

> Kristian Kvilekval <[email protected]> writes:
> 
>>> The second and subsequent times it starts up, but with a couple of errors:
>>> /usr/lib/zinf/plugins/cd.lmc: undefined symbol: _ZN12PipelineUnit5PauseEv
>>> /usr/lib/zinf/plugins/wav.lmc: undefined symbol: _ZN12PipelineUnit5PauseEv
>>> 
>>> The problem is the PipelineUnit class.  It's part of libio, and
>>> libio is in zinf_LDADD, however nothing in zinf mainline code
>>> refers to this class, so this class never gets linked into the main
>>> executable.  It's referenced from these two plugins, but because
>>> the class never got linked into the main executable, the plugins
>>> fail to load.
>>> 
>>> Here's an ugly hack that'll force a reference, and get the class
>>> included in the main executable.  A proper fix would be to change
>>> the makefiles somehow...
>>> 
>>> After I fixed that, with the following hack, I discovered that the 
>>> EventBuffer class similarly needs to be manually hacked in:
>>> 
>>> --- base/src/player.cpp.orig	2003-07-22 17:15:38.000000000 -0400
>>> +++ base/src/player.cpp	2003-07-22 21:21:48.000000000 -0400
>>> @@ -2264,3 +2264,13 @@
>>>  
>>>      delete pmo;
>>>  }
>>> +
>>> +#include "pipeline.h"
>>> +#include "eventbuffer.h"
>>> +
>>> +static void hack()
>>> +{
>>> +	PipelineUnit hack1(NULL);
>>> +	EventBuffer hack2(0, 0, NULL);
>>> +}
>>> +
>>
>> Eek. Andreas is there a better for this?
>>
> Hmm in theory, this shouldn't be necessary, as we have in io/cd/Makefile.am:
> 
> cd_pmo_la_LIBADD = $(top_builddir)/io/libio.la
> 
> This should link in the needed class, and I in fact have all the
> PipelineUnit methods in the cd.pmo plugin on my system (in section
> .text).

It's cd.lmc, not cd.pmo:

# zinf
/usr/lib/zinf/plugins/cd.lmc: undefined symbol: _ZN12PipelineUnit5PauseEv
/usr/lib/zinf/plugins/wav.lmc: undefined symbol: _ZN12PipelineUnit5PauseEv

Looks like you need to fix up lmc/cd/Makefile.am, and lmc/wav/Makefile.am

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQA/JLIdx9p3GYHlUOIRAo9vAJ426QgxGUmYJv1nboD8KI2LPKee1QCfWsHL
jJkKQ2kgCw+lkLJLnZtkPUY=
=IVVc
-----END PGP SIGNATURE-----