Re: [PATCH v5 66/75] usb: gadget: udc: make udc-core build in u-boot

Mattijs Korpershoek <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <[email protected]>
Hi Anders,

Thank you for the patch.

On Thu, Jul 16, 2026 at 15:42, Anders Roxell <[email protected]> wrote:

> The resynced udc-core is kernel code. Drop what u-boot does not need and
> hook it into the build.
>
> Co-developed-by: Jerome Forissier <[email protected]>
> Signed-off-by: Jerome Forissier <[email protected]>
> Co-developed-by: Jens Wiklander <[email protected]>
> Signed-off-by: Jens Wiklander <[email protected]>
> Signed-off-by: Anders Roxell <[email protected]>

Please run checkpatch.pl on this. There are lots of errors/warnings
here:

total: 74 errors, 66 warnings, 6 checks, 1369 lines checked

A lot of them are whitespace related, such as

WARNING: please, no spaces at the start of a line
ERROR: code indent should use tabs where possible

Because of the spaces versus tabs mixup, the diff is un-necessarily big
and difficult to review.

Therefore, I won't do a thorough review on this for now.

Please fix this for v6.

Thanks
Mattijs
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.