Re: [PATCH v2] fwu: Make boottime check failures visible

Ilias Apalodimas <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <CAC_iWjK_1_k_MWvYOAWAS6pe=-waZs0Ht=71Zigt1vEbsE6rJg@mail.gmail.com>
Does this apply for you on -main?

Cheers
/Ilias

On Tue, 28 Jul 2026 at 15:48, Ilias Apalodimas
<[email protected]> wrote:
>
> Hi Michal,
>
> Yea, I'll send a PR tomorrow
>
> Cheers
> /Ilias
>
> On Tue, 28 Jul 2026 at 08:19, Michal Simek <[email protected]> wrote:
> >
> > Hi Ilias,
> >
> > On 7/7/26 14:16, Michal Simek wrote:
> > > On systems with FWU enabled but without the required DT changes the
> > > boottime checks fail. The failures are only reported via log_debug()
> > > which is compiled out by default, so the user has no idea what is going
> > > on.
> > >
> > > Use log_err() to make these failures visible.
> > >
> > > Signed-off-by: Michal Simek <[email protected]>
> > > Reviewed-by: Ilias Apalodimas <[email protected]>
> > > ---
> > >
> > > Changes in v2:
> > > - drop fwu: Gracefully handle missing FWU metadata device
> > >
> > >   lib/fwu_updates/fwu.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/lib/fwu_updates/fwu.c b/lib/fwu_updates/fwu.c
> > > index 2b11e5da061d..e9bb1b4fc656 100644
> > > --- a/lib/fwu_updates/fwu.c
> > > +++ b/lib/fwu_updates/fwu.c
> > > @@ -759,7 +759,7 @@ static int fwu_boottime_checks(void)
> > >
> > >       ret = uclass_first_device_err(UCLASS_FWU_MDATA, &g_dev);
> > >       if (ret) {
> > > -             log_debug("Cannot find fwu device\n");
> > > +             log_err("Cannot find fwu device\n");
> > >               return ret;
> > >       }
> > >
> > > @@ -771,7 +771,7 @@ static int fwu_boottime_checks(void)
> > >
> > >       ret = fwu_init();
> > >       if (ret) {
> > > -             log_debug("fwu_init() failed\n");
> > > +             log_err("fwu_init() failed\n");
> > >               return ret;
> > >       }
> > >
> > > ---
> > > base-commit: 313a1a7bb065319dd3d57e9ab6559422771aebae
> > > branch: debian-sent3
> > >
> >
> > Can you please pick up this patch?
> >
> > Thanks,
> > Michal
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.