Re: [PATCH v2 08/11] rockchip: doc: add boot medium layout text

Simon Glass <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <CAFLszThHfKipCfGpjQ+S3cO4YzhkXwWOytRGmstGrUtxMhXh4Q@mail.gmail.com>
Hi Johan,

On 2026-07-28T06:51:38, Johan Jonker <[email protected]> wrote:
> rockchip: doc: add boot medium layout text
>
> Add text that explains the boot medium layout options.
>
> Signed-off-by: Johan Jonker <[email protected]>
>
> doc/board/rockchip/rockchip.rst | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)

> +The boot ROM only checks a boot medium for a limited number of pages or blocks for data.
> +It is not possible to place these blocks randomly.

Please wrap these prose lines to around 80 columns like the rest of
rockchip.rst - several run well past 100.

> +  Rockchip uses a unified GPT partition layout for it's the open source products.
> +  With this GPT partition layout U-Boot can be compatible with other components,
> +  like miniloader, trusted-os, arm-trust-firmware.

As Stefan says, 'for it's the open source products' doesn't parse - I
think you mean 'for its open source products'. Also
'arm-trust-firmware' should be 'arm-trusted-firmware'

> +  Write u-boot-rockchip.bin to offset 64.
> +
> +* SPI:
> +
> +  Write u-boot-rockchip-spi.bin to offset 0.

The Flashing section below uses seek=64, i.e. 512-byte blocks. Please
state the unit here (e.g. 'blocks 64'), and likewise for the SPI
offset 0.

Regards,
Simon
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.