Re: [PATCH v2 11/11] rockchip: doc: remove README.rockchip

Simon Glass <[email protected]>
Newsgroups gmane.comp.boot-loaders.u-boot
Message-ID <CAFLszThaodJJSsJ6tV0DVPd2uHR7b-YL9yhm7EB5jjXqRP-7Fg@mail.gmail.com>
Hi Johan,

On 2026-07-28T06:51:38, Johan Jonker <[email protected]> wrote:
> rockchip: doc: remove README.rockchip
>
> Remove README.rockchip for info that's already in
> rockchip.rst or no longer applicable.
>
> Signed-off-by: Johan Jonker <[email protected]>
>
> doc/README.rockchip | 677 ----------------------------------------------------
>  1 file changed, 677 deletions(-)

> diff --git a/doc/README.rockchip b/doc/README.rockchip
> deleted file mode 100644
> @@ -1,677 +0,0 @@
> -rkimage
> --------
> -
> -rkimage.c produces an SPL image suitable for sending directly to the boot ROM
> -over USB OTG. This is a very simple format - just the string RK32 (as 4 bytes)
> -followed by u-boot-spl-dtb.bin.

Patches 9 and 10 moved the rksd and rkspi sections into rksd.c and
rkspi.c, but the rkimage section here has no equivalent home, so this
information is lost. tools/rkimage.c still says:

    * See README.rockchip for details of the rkimage format

so that reference becomes dangling. Please move this section into
rkimage.c to match the other two.

> diff --git a/doc/README.rockchip b/doc/README.rockchip
> deleted file mode 100644
> @@ -1,677 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0+

BTW doc/README.rockusb line 41 also refers here:

    see doc/README.rockchip for more detail about how to get U-Boot binary.

That should be repointed at doc/board/rockchip/rockchip.rst (or dropped).

Regards,
Simon
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.