Re: [PATCH v6 3/5] binman: ti_secure: drop the redundant keyfile re-read

Sergio Prado <[email protected]> Fri, 7 Aug 2026 10:19:01 -0300

Newsgroups	gmane.comp.boot-loaders.u-boot.general,gmane.comp.boot-loaders.u-boot
Message-ID	<CANu7NGvxhMyMLC3pss-2NO6XibmxKGTB6fAZCsS9N4+xGLv3BQ@mail.gmail.com>

Hi Simon,

Thanks for reviewing.

Em qua., 5 de ago. de 2026 às 15:58, Simon Glass <[email protected]> escreveu:
>
> Hi Sergio,
...
> > diff --git a/tools/binman/etype/ti_secure_rom.py b/tools/binman/etype/ti_secure_rom.py
> > @@ -71,8 +70,6 @@ class Entry_ti_secure_rom(Entry_x509_cert):
> >          self.sha = fdt_util.GetInt(self._node, 'sha', 512)
> >          self.core = fdt_util.GetString(self._node, 'core', 'secure')
> >          self.bootcore_opts = fdt_util.GetInt(self._node, 'core-opts')
> > -        self.key_fname = self.GetEntryArgsOrProps([
> > -            EntryArg('keyfile', str)], required=True)[0]
>
> BTW Entry_ti_secure_rom.ReadNode() also re-reads 'sw-rev' with the
> parent's default (line 70) - same pattern. Folding it in would leave
> no redundant re-reads at all. Could be a follow-up perhaps?

Makes sense. I will send a follow-up.

Best regards,

Sergio Prado