Re: [PATCH 01/15] clk: rockchip: pll: Fix double use of postdiv1
Quentin Schulz <[email protected]>
| Newsgroups | gmane.comp.boot-loaders.u-boot |
|---|---|
| Message-ID | <2ea33062-459d-4d72-b85b-46c7b1fedde7__34435.2348287188$1786108821$gmane$org@cherry.de> |
Hi Jonas,
On 7/30/26 4:12 PM, Jonas Karlman wrote:
> The possible frac_rate part of rk3036_pll plls is divided two times by
> postdiv1 instead of both postdiv1 and postdiv2 as the integer part. Fix
> this by using postdiv2 in the second do_div() call.
>
Fixes: bbda2ed5840c ("rockchip: clk: pll: add common pll setting funcs")
Reviewed-by: Quentin Schulz <[email protected]>
I've checked RK3308, RK3506, RK3568 and RV1126 TRMs, they all have this
formula (well, RK3308 divides FRAC by 224 instead of 2^24 but I'm
assuming this is a typo in the TRM). I couldn't find a TRM for RK3528
yet but I'm assuming it's going to follow the same formula.
Cheers,
Quentin