Re: [PATCH v2 3/4] pinctrl: mediatek: simplify Kconfig

Hi David,

On 8/7/26 9:16 PM, David Lechner wrote:
> Change the MediaTek pinctrl Kconfig to just have a single option for
> all targets. This will simplify adding new targets and SPL support in
> the future.
> 
> There is only one MediaTek target that does not have a pinctrl driver.
> All other targets enable it by default so the configs don't have to
> explicitly set it in addition to just enabling PINCTRL.
> 

Wondering if we shouldn't simply disable it in MT8183 defconfigs now 
that the symbol can be disabled? I'm assuming the day we have a driver 
for the MT8183 pinctrl controller we will switch this back to default y 
for this SoC as well. The issue would be that the day we do that, all 
MT8183 defconfigs enable the pinctrl driver by default which may not be 
wanted. By disabling it in the defconfigs, it means it needs to be a 
conscious choice to enable the driver once it's supported. What do you 
think?

> In the Makefile, we can use the target config symbol to automatically
> select the correct driver. And the config selector on the common file
> was redundant since we already have the same in the parent Makefile,
> so it is dropped. Targets are also sorted while we are touching this.
> 

Acked-by: Quentin Schulz <[email protected]>

Thanks!
Quentin