Re: [PATCH] rockchip: rk3576-rock-4d: Enable XMC SPI chip

Hi Martin,

On 8/9/26 12:07 AM, Martin Herren wrote:
> The Radxa Rock 4D exists also with a different SPI flash chip than the
> one specified in the schematic[1]: XMC XM25QU128C.
> At least board revision V1.12 can be impacted.
> 
> Enable CONFIG_SPI_FLASH_XMC Kconfig options.
> 
> Without this SPL fails to probe the SPI and thus fails to load u-boot

the SPI flash

> proper from SPI.
> 
> Vendor u-boot also enables CONFIG_SPI_FLASH_GIGADEVICE and
> CONFIG_SPI_FLASH_WINBOND so other hardware configuration might exist.
> They are not enabled by this patch.
> 

This patch here matches what's been done in Radxa downstream U-Boot in 
commit 2742c75cc288 ("configs: rk3576 series: enable 
CONFIG_SPI_FLASH_XMC") so fine with me. However, it doesn't apply. I'm 
assuming the issue is the CONFIG_SPI_FLASH_MACRONIX=y line being split 
in two in the git context just above the new CONFIG_SPI_FLASH_XMC=y 
line. Can you please send a v2 with a patch that can be applied?

Try to properly capitalize U-Boot while at it :)

Cheers,
Quentin

> [1] https://dl.radxa.com/rock4/4d/docs/hw/Radxa_ROCK_4D_SCH_V1.12.pdf
> 
> Signed-off-by: Martin Herren <[email protected]>
> ---
>   configs/rock-4d-rk3576_defconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/configs/rock-4d-rk3576_defconfig b/configs/rock-4d-rk3576_defconfig
> index 7228a9d879a..93faf09962c 100644
> --- a/configs/rock-4d-rk3576_defconfig
> +++ b/configs/rock-4d-rk3576_defconfig
> @@ -49,6 +49,7 @@ CONFIG_MMC_DW=y
>   CONFIG_MMC_DW_ROCKCHIP=y
>   CONFIG_SPI_FLASH_SFDP_SUPPORT=y
>   CONFIG_SPI_
> FLASH_MACRONIX=y
> +CONFIG_SPI_FLASH_XMC=y
>   CONFIG_DWC_ETH_QOS=y
>   CONFIG_DWC_ETH_QOS_ROCKCHIP=y
>   CONFIG_PHY_REALTEK=y
> 
> ---
> base-commit: d0615e4a67c8958fad4a8c39262074958f04c179
> change-id: 20260808-rk3576_radxa-rock-4_spi-9c241f4e29e5
> 
> Best regards,
> --
> Martin Herren <[email protected]>
>