Re: ...Wrong email addresses for PR 'responsible' persons

Chad Walstrom <[email protected]> Thu, 18 Nov 2004 14:53:44 -0600
Newsgroups gmane.comp.bug-tracking.gnats.bugs
Message-ID <[email protected]>
--===============0143660306==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="m972NQjnE83KvVa/"
Content-Disposition: inline


--m972NQjnE83KvVa/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Nadim Shaikli <[email protected]> wrote:
> ### Patch - Begin
> --- gnatsweb.pl.orig	2004-11-05 12:09:49.000000000 -0800
> +++ gnatsweb.pl	2004-11-05 15:33:04.000000000 -0800
> @@ -2144,10 +2144,14 @@
>  # if it's not a full address, $site_mail_domain is appended first
>  sub make_mailto {
>      my $string =3D shift;
> -    if ($string !~ /@/) {
> -	$string =3D qq*<a href=3D"mailto:${string}${site_mail_domain}">$string<=
/a>*;
> +    my $addr =3D exists($responsible_address{$string}) ?
> +	  $responsible_address{$string} : $string;
> +    my $fullname =3D exists($responsible_fullname{$string}) ?
> +	  $responsible_fullname{$string} : $string;
> +    if ($addr !~ /@/) {
> +	$string =3D qq*<a href=3D"mailto:${addr}${site_mail_domain}">$fullname<=
/a>*;
>      } else {
> -	$string =3D qq*<a href=3D"mailto:$string">$string</a>*;
> +	$string =3D qq*<a href=3D"mailto:$addr">$fullname</a>*;
>      }
>     =20
>      return $string;
> ### Patch - End
>=20
> Hope this gets included.

For what it's worth, I think this patch works beautifully.  We're using
it now at work and have had favorable remarks.  (I added the modified
sub call to our gnatsweb-site.pl file.)  Nadim, could you add this patch
to the http://savannah.gnu.org/patch/?group=3Dgnats website?  Yngve will
see to it from there.

--=20
Chad Walstrom <[email protected]>           http://www.wookimus.net/
           assert(expired(knowledge)); /* core dump */

--m972NQjnE83KvVa/
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFBnQvYDMcLGCBsWv0RAvJpAKCght0parskQea2SIxtTZB2tEmXCACgkb/5
1PeJ1HyA0cHukdiAHjeEOUs=
=hGBJ
-----END PGP SIGNATURE-----

--m972NQjnE83KvVa/--



--===============0143660306==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Bug-gnats mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/bug-gnats

--===============0143660306==--