Re: Patch review expectations
Joseph Myers <[email protected]>
| Newsgroups | gmane.comp.bug-tracking.roundup.devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 27 Sep 2018, Ralf Schlatterbeck wrote: > > (I have a third > > unresolved patch from 2012 - issue2550750 - but in that case there were > > some concerns raised in the discussion, although I still think the patch > > is correct as-is, both as a matter of being consistent with the intent of > > the existing code quoted in the discussion in that issue and as a matter > > of the general principle that "a user's network connection had problems > > while they were accessing a website" is a matter for that user, not > > something for the site to generate an automatic email to the admin about.) > > Do you have a timeline when this discussion happened or was this > discussed in an issue and do you have a link to it? > Thanks for following up to these issues! All the discussion is in the issue: http://issues.roundup-tracker.org/issue2550750 (I have a trivially updated version of the patch, updated for the Python 3 changes to "except" syntax in the diff context so that it applies cleanly to current sources.) -- Joseph S. Myers [email protected]