Re: Patch review expectations
"John P. Rouillard" <[email protected]>
| Newsgroups | gmane.comp.bug-tracking.roundup.devel |
|---|---|
| Message-ID | <[email protected]> |
In message <[email protected]>, Joseph Myers writes: >On Thu, 27 Sep 2018, John P. Rouillard wrote: > >> Hi Joseph: >> In message <[email protected]>, >> Joseph Myers writes: >> >When should one commit one's own patches without review, versus waiting >> >for them to be reviewed? >> > >> >I've generally been committing Python-3-related patches without expecting >> >review for them. But I also have some other bug-fix patches attached to >> >tracker issues without review (since 2014 in one case). Should I just >> >commit these (with appropriate CHANGES.txt updates) if no concerns have >> >been raised about them? >> >> Do you have links to the issues? > >The ones for which I've now committed my fixes are: > >http://issues.roundup-tracker.org/issue2550722 >http://issues.roundup-tracker.org/issue2550992 > >(There are a lot more non-closed issues in the tracker with patches >attached that need review, from lots of different people.) Yup I would say 3/4 of the fixes in 1.6.0 were from existing patches that I got into the code. -- -- rouilj John Rouillard =========================================================================== My employers don't acknowledge my existence much less my opinions. On Thu, 27 Sep 2018, John P. Rouillard wrote: > Hi Joseph: > In message <[email protected]>, > Joseph Myers writes: > >When should one commit one's own patches without review, versus waiting > >for them to be reviewed? > > > >I've generally been committing Python-3-related patches without expecting > >review for them. But I also have some other bug-fix patches attached to > >tracker issues without review (since 2014 in one case). Should I just > >commit these (with appropriate CHANGES.txt updates) if no concerns have > >been raised about them? > > Do you have links to the issues? The ones for which I've now committed my fixes are: http://issues.roundup-tracker.org/issue2550722 http://issues.roundup-tracker.org/issue2550992 (There are a lot more non-closed issues in the tracker with patches attached that need review, from lots of different people.) -- Joseph S. Myers [email protected]