Re: Shipping optional components with tracker

Hi John!

* John P. Rouillard <[email protected]> [20191106 04:01]:
> On https://issues.roundup-tracker.org/issue2550926 I came up with a
> patch to the standard statusauditor.py. The patch will change the
> status from new to chatting only if the email/update is not done by
> the same person who created the ticket. (Currently any update changes
> the status.)

Sounds good, I have commented in the issue.

> If I was to merge it into the default trackers, I thought of adding a
> detectors/config.ini. So the option could be turned on by editing the
> config file rather than the python code. Currently we don't ship
> config.ini for extensions or detectors.
> 
> Details on the extra config.ini files can be found at:
> 
> http://roundup.sourceforge.net/docs/customizing.html#extending-the-configuration-file
> 
> I thought a section in detectors/config.ini like:
> 
> [statusauditor]
> chating_in_new_user = False
> 
> to disable the option by default.
> 
> Quips, comments, thoughts???

In our own template (https://hg.intevation.de/roundup/fast-decomposed/)
we already include extendings/config.ini to enable/disable some
optional features. This works very well, so I consider it a good
idea to do the same for detectors/config.ini

"chating_in_new_user" (based on the patch name in the issue, I guess
you meant "chatting_on_new_user") needs a better name though.
I suggest "chatting_ignore_issue_creator" and inverting the logic,
because "chatting_on_issue_creator" might more easily imply that
chatting is already set when creating the issue.

Regards,

Thomas

-- 
Thomas Arendsen Hein <[email protected]>
OpenPGP key: https://intevation.de/~thomas/thomas_pgp.asc (0xD45DE28FF3A2250C)
Intevation GmbH, Neuer Graben 17, 49074 Osnabrueck - AG Osnabrueck, HR B 18998
Geschaeftsfuehrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner