Re: Shipping optional components with tracker

Hi Thomas:

In message <[email protected]>,
Thomas Arendsen Hein writes:
>* John P. Rouillard <[email protected]> [20191106 04:01]:
>> On https://issues.roundup-tracker.org/issue2550926 I came up with a
>> patch to the standard statusauditor.py. The patch will change the
>> status from new to chatting only if the email/update is not done by
>> the same person who created the ticket. (Currently any update changes
>> the status.)
>
>Sounds good, I have commented in the issue.
>
>> If I was to merge it into the default trackers, I thought of adding a

Note that only classic and jinja templates have this implemented.

Minimal, devel and responsive have this turned off or missing.

>> detectors/config.ini. So the option could be turned on by editing the
>> config file rather than the python code. [...]
>> I thought a section in detectors/config.ini like:
>> 
>> [statusauditor]
>> chating_in_new_user = False
>> 
>> to disable the option by default.
>> 
>> Quips, comments, thoughts???
>
>In our own template (https://hg.intevation.de/roundup/fast-decomposed/)
>we already include extendings/config.ini to enable/disable some
>optional features. This works very well, so I consider it a good
>idea to do the same for detectors/config.ini
>
>"chating_in_new_user" (based on the patch name in the issue, I guess
>you meant "chatting_on_new_user") needs a better name though.
>I suggest "chatting_ignore_issue_creator" and inverting the logic,
>because "chatting_on_issue_creator" might more easily imply that
>chatting is already set when creating the issue.

In the patch the variable that enables this feature is called:

  allow_multiple_initial_emails

so all initial emails (as determined by issue creator/ message author
match) will keep the status at unread.

Alternate names:

  chatting_requires_two_people

  chatting_status_on_second_user_update

I really need an entire sentence to make it clear. I am considering
calling it Fred and just adding:

   [statusauditor]
   # Options for statusauditor.py
   #
   # Assume an issue has a status of unread and was created by the
   # demo user.
   # If False, a new message on an issue sets status to chatting.
   # If True, a new message sets the status to chatting only if the
   #   author of the new message is not demo. A message sent by demo
   #   keeps the issue status at unread.
   fred = False                                        

8-/   

--
				-- rouilj
John Rouillard
===========================================================================
My employers don't acknowledge my existence much less my opinions.