Re: roundup.cgi.actions.ExportCSVAction broken?

Created roundup tracker issue 2551019 for this error. Not sure who to contact to let them know about it. I attached an hg diff file to the issue.


[cid:af96a827-1839-4d67-a9bd-882c37325d14]



________________________________
From: Ralf Schlatterbeck <[email protected]>
Sent: Wednesday, February 6, 2019 12:38 AM
To: [email protected]
Subject: Re: [Roundup-users] roundup.cgi.actions.ExportCSVAction broken?

Hello Tom,
On Tue, Feb 05, 2019 at 06:41:18PM +0000, Tom Ekberg wrote:
>
>   TypeError: byte string value expected, value of type str found
...
> I'd suggest changing the above write method to something
> like this:
>
>
>     def write(self, data):
>         f = self.request.get_wfile()
>         self.write = f
>         return f(data.encode('utf-8') if isinstance(data, str) else data)
>
> Is it just me or have you seen this problem too?

Thanks for the report.
I guess you're the first person to test the python3 changes with WSGI.
So, yes, I think you've found a bug. Can you test your proposed
modification (looks good to me) and report back if this works for you?
If you can give the modification as a patch (diff -u of the changes
against the latest version) it's easier to apply.

Also fine would be an issue in our issue-tracker:
https://issues.roundup-tracker.org/
List of issues - Roundup tracker<https://issues.roundup-tracker.org/>
issues.roundup-tracker.org
Last modified: Thu Dec 27 04:16:43 EST 2018



Thanks,
Ralf
--
Dr. Ralf Schlatterbeck                  Tel:   +43/2243/26465-16
Open Source Consulting                  www:   http://www.runtux.com
Reichergasse 131, A-3411 Weidling       email: [email protected]


_______________________________________________
Roundup-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/roundup-users

_______________________________________________
Roundup-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/roundup-users